Skip to content

[3.11] gh-102558: [Enum] fix AttributeError during member repr() (GH-102601) #102977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Mar 23, 2023
Merged

[3.11] gh-102558: [Enum] fix AttributeError during member repr() (GH-102601) #102977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-102558: [Enum] fix AttributeError during member repr() (GH-102601) 
(cherry picked from commit bd06375)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
  • Loading branch information
@corona10 @miss-islington
corona10 authored and miss-islington committed Mar 23, 2023
commit 9963aa7b941a458d1eef0629ac018f8070eb01be
2 changes: 2 additions & 0 deletions Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,6 +1187,8 @@ def _missing_(cls, value):
return None

def __repr__(self):
if not isinstance(self, Enum):
return repr(self)
v_repr = self.__class__._value_repr_ or repr
return "<%s.%s: %s>" % (self.__class__.__name__, self._name_, v_repr(self._value_))

Expand Down
9 changes: 8 additions & 1 deletion Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import builtins as bltns
from collections import OrderedDict
from datetime import date
from enum import Enum, IntEnum, StrEnum, EnumType, Flag, IntFlag, unique, auto
from enum import Enum, EnumMeta, IntEnum, StrEnum, EnumType, Flag, IntFlag, unique, auto
from enum import STRICT, CONFORM, EJECT, KEEP, _simple_enum, _test_simple_enum
from enum import verify, UNIQUE, CONTINUOUS, NAMED_FLAGS, ReprEnum
from enum import member, nonmember, _iter_bits_lsb
Expand Down Expand Up @@ -632,6 +632,13 @@ class MySubEnum(MyEnum):
theother = auto()
self.assertEqual(repr(MySubEnum.that), "My name is that.")

def test_multiple_superclasses_repr(self):
class _EnumSuperClass(metaclass=EnumMeta):
pass
class E(_EnumSuperClass, Enum):
A = 1
self.assertEqual(repr(E.A), "<E.A: 1>")

def test_reversed_iteration_order(self):
self.assertEqual(
list(reversed(self.MainEnum)),
Expand Down