Skip to content

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives #102816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 2 commits into from
Mar 19, 2023
Merged

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives #102816

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a4c4c
gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternat…
iritkatriel Mar 18, 2023
103dc3c
fix refleak
iritkatriel Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix refleak
  • Loading branch information
@iritkatriel
iritkatriel committed Mar 18, 2023
commit 103dc3c4f6ac0b204a17565dcf6644f660e24365
4 changes: 3 additions & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2324,6 +2324,7 @@ remove_importlib_frames(PyThreadState *tstate)
int always_trim = 0;
int in_importlib = 0;
PyObject **prev_link, **outer_link = NULL;
PyObject *base_tb = NULL;

/* Synopsis: if it's an ImportError, we trim all importlib chunks
from the traceback. We always trim chunks
Expand All @@ -2339,7 +2340,7 @@ remove_importlib_frames(PyThreadState *tstate)
}

assert(PyExceptionInstance_Check(exc));
PyObject *base_tb = PyException_GetTraceback(exc);
base_tb = PyException_GetTraceback(exc);
prev_link = &base_tb;
PyObject *tb = base_tb;
while (tb != NULL) {
Expand Down Expand Up @@ -2376,6 +2377,7 @@ remove_importlib_frames(PyThreadState *tstate)
}
PyException_SetTraceback(exc, base_tb);
done:
Py_XDECREF(base_tb);
_PyErr_SetRaisedException(tstate, exc);
}

Expand Down