Skip to content

[3.11] Increase stack reserve size for Windows debug builds to avoid test crashes (GH-102764) #102770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Mar 17, 2023
Merged

[3.11] Increase stack reserve size for Windows debug builds to avoid test crashes (GH-102764) #102770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Increase stack reserve size for Windows debug builds to avoid test cr… 
…ashes (GH-102764)

(cherry picked from commit f33b33e)

Co-authored-by: Steve Dower <steve.dower@python.org>
  • Loading branch information
@zooba @miss-islington
zooba authored and miss-islington committed Mar 17, 2023
commit e1e8e06af00096e429c7b7eab8b50a6a527d095c
2 changes: 1 addition & 1 deletion PCbuild/python.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<Link>
<SubSystem>Console</SubSystem>
<StackReserveSize Condition="$(Configuration) != 'Debug'">2000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'Debug'">4000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'Debug'">8000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion PCbuild/pythonw.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@
</PropertyGroup>
<ItemDefinitionGroup>
<Link>
<StackReserveSize>2000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) != 'Debug'">2000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'Debug'">8000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down