Skip to content

gh-102578: Optimise setting and deleting mutable attributes on non-dataclass subclasses of frozen dataclasses #102573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 15 commits into from
Mar 11, 2023
Merged

gh-102578: Optimise setting and deleting mutable attributes on non-dataclass subclasses of frozen dataclasses #102573

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
776843d
Use `set`-based name lookup rather than `tuple`s for frozen dataclasses
XuehaiPan Mar 10, 2023
0a400c1
Merge branch 'main' into dataclasses-lookup
XuehaiPan Mar 10, 2023
54dd9c3
Add news entry
XuehaiPan Mar 10, 2023
845c8ff
Update new entry
XuehaiPan Mar 10, 2023
0f0d97c
Use empty tuple singleton in simple case
XuehaiPan Mar 10, 2023
0524ee4
Update new entry
XuehaiPan Mar 10, 2023
4055fa3
Add more details about the change in news entry
XuehaiPan Mar 10, 2023
0bbf3a8
Update news entry
XuehaiPan Mar 10, 2023
05eae2c
Merge branch 'main' into dataclasses-lookup
XuehaiPan Mar 10, 2023
b90d251
Eliminate unnecessary check for empty fields
XuehaiPan Mar 10, 2023
d3c8403
Remove mistake from auto import
XuehaiPan Mar 10, 2023
84b5bdd
Add test for empty frozen dataclass
XuehaiPan Mar 10, 2023
2d38e9c
Add test for empty frozen dataclass
XuehaiPan Mar 10, 2023
ef8e83f
Add test for empty frozen dataclass
XuehaiPan Mar 10, 2023
5da787e
Add extra check for the exception type
XuehaiPan Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update new entry
  • Loading branch information
@XuehaiPan
XuehaiPan committed Mar 10, 2023
commit 845c8ffb36ea8291788e5e70ec6b6655e73ce43d
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2023-03-10-10-10-00.gh-issue-102573.GQ7sV6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Use ``set``-based name lookup rather than ``tuple``s for frozen dataclasses
Use ``set``-based name lookup rather than ``tuple``\s for frozen dataclasses
Comment thread
XuehaiPan marked this conversation as resolved.
Outdated