Skip to content

gh-102542 Refactor the mime audio module #102540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JosephSBoyle wants to merge 9 commits into from
Closed

gh-102542 Refactor the mime audio module #102540

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
496bbec
Refactor the mime audio module
JosephSBoyle Mar 8, 2023
3561ee9
Improve comparisons in _infer_subtype
JosephSBoyle Mar 8, 2023
15cd8ad
Add a test for inferring the audio content subtypes
JosephSBoyle Mar 9, 2023
5b26332
Make the infer audio content subtypes test more robust
JosephSBoyle Mar 9, 2023
1b4b061
Remove newly added redundant tests
JosephSBoyle Mar 11, 2023
3ebbfae
Merge branch 'main' into refactor-mime-audio
JosephSBoyle Mar 27, 2023
114e324
Merge branch 'python:main' into refactor-mime-audio
JosephSBoyle May 23, 2023
1f1efa5
Merge branch 'main' into refactor-mime-audio
JosephSBoyle Jun 12, 2023
9d21be1
Merge branch 'main' into refactor-mime-audio
JosephSBoyle Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve comparisons in _infer_subtype
  • Loading branch information
@JosephSBoyle
JosephSBoyle committed Mar 9, 2023
commit 3561ee9f6f563ea75553f90cc6d687d852b6b051
4 changes: 2 additions & 2 deletions Lib/email/mime/audio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def __init__(self, _audiodata, _subtype=None,


def _infer_subtype(h: bytes) -> str:
"""Infer the audio format based on the data's header"""
if h.startswith(b'FORM') and h[8:12] in (b'AIFC', b'AIFF'):
return 'x-aiff'
elif h.startswith(b'.snd'):
return 'basic'
elif h.startswith(b'RIFF') and h[8:12] == b'WAVE' and h[12:16] == b'fmt ':
# 'RIFF' <len> 'WAVE' 'fmt ' <len>
elif h.startswith(b'RIFF') and h[8:16] == b'WAVEfmt ':
return 'x-wav'

raise TypeError('Could not find audio MIME subtype')