Skip to content

gh-102493: fix normalization in PyErr_SetObject #102502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 8 commits into from
Mar 7, 2023
Merged

gh-102493: fix normalization in PyErr_SetObject #102502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
077747d
add test for PyErr_SetObject
iritkatriel Mar 7, 2023
feef425
fix normalization in PyErr_SetObject
iritkatriel Mar 7, 2023
c211d86
add news
iritkatriel Mar 7, 2023
cea7ff9
rename news file
iritkatriel Mar 7, 2023
61c6615
assert not null
iritkatriel Mar 7, 2023
a9094f9
skip issubclass when not an exception
iritkatriel Mar 7, 2023
6d7bccd
whitespace
iritkatriel Mar 7, 2023
fd01812
fix refleak when is_subclass fails
iritkatriel Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix refleak when is_subclass fails
  • Loading branch information
@iritkatriel
iritkatriel committed Mar 7, 2023
commit fd0181213a05ff99dc8c6e61d052a461860e7555
9 changes: 9 additions & 0 deletions Lib/test/test_capi/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,15 @@ def test_set_object(self):
_testcapi.exc_set_object(OSError, PermissionError(24))
self.assertEqual(e.exception.args, (24,))

class Meta(type):
def __subclasscheck__(cls, sub):
1/0

class Broken(Exception, metaclass=Meta):
pass

with self.assertRaises(ZeroDivisionError) as e:
_testcapi.exc_set_object(Broken, Broken())

if __name__ == "__main__":
unittest.main()
2 changes: 1 addition & 1 deletion Python/errors.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ _PyErr_SetObject(PyThreadState *tstate, PyObject *exception, PyObject *value)
exception);
return;
}
Py_XINCREF(value);
/* Normalize the exception */
int is_subclass = 0;
if (value != NULL && PyExceptionInstance_Check(value)) {
Expand All @@ -158,6 +157,7 @@ _PyErr_SetObject(PyThreadState *tstate, PyObject *exception, PyObject *value)
return;
Comment thread
iritkatriel marked this conversation as resolved.
}
}
Py_XINCREF(value);
if (!is_subclass) {
/* We must normalize the value right now */
PyObject *fixed_value;
Expand Down