Skip to content

gh-102402: Fix floating point math issue by using time.time_ns() in logging.LogRecord #102412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 24 commits into from
Apr 16, 2024
Merged

gh-102402: Fix floating point math issue by using time.time_ns() in logging.LogRecord #102412

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
2f046c2
Add test for 102402 100msecs
dougthor42 Mar 4, 2023
2460f88
Update logging.LogRecord to use time_ns.
dougthor42 Mar 4, 2023
059f856
Simplify msecs calculation
dougthor42 Mar 4, 2023
997bd41
Add blurb
dougthor42 Mar 4, 2023
2e7cde3
Fix comments, remove superfluous comment
dougthor42 Mar 4, 2023
5505cea
Merge branch 'main' into fix-gh-102402-logging-msecs
dougthor42 Mar 4, 2023
411a421
Switch to math algorithm rather than string manipulation.
dougthor42 Mar 5, 2023
d3a1f78
Correct and update comment
dougthor42 Apr 15, 2023
5fa370b
Use unittest.mock.patch instead of manual monkeypatching
dougthor42 Apr 15, 2023
39cab9d
formatting in test_logging.py
dougthor42 Mar 2, 2024
920bf74
Update docs
dougthor42 Mar 2, 2024
8bdc406
Keep ref to gh-89047
dougthor42 Mar 2, 2024
bf68b26
Use modulo arithmetic, update comment
dougthor42 Mar 2, 2024
e404ca0
Add comment
dougthor42 Mar 2, 2024
9661499
Correct comment
dougthor42 Mar 3, 2024
ec74b0e
Rename test
dougthor42 Mar 3, 2024
710f3ac
Add test for relativeCreated
dougthor42 Mar 3, 2024
ff8140c
remove issue num from test names; move to comment
dougthor42 Mar 3, 2024
fd45694
Use importhelper instead of importlib.reload
dougthor42 Mar 3, 2024
84b931b
Also assert record.created
dougthor42 Mar 3, 2024
5a604f9
Update test to check multiple offset values
dougthor42 Mar 3, 2024
dc90919
Optimize loop vs import CM
dougthor42 Mar 4, 2024
502ff65
Move item to variable
dougthor42 Mar 4, 2024
65ea1b5
Merge branch 'main' into fix-gh-102402-logging-msecs
vsajip Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@dougthor42
dougthor42 committed Mar 2, 2024
commit e404ca08a04c08c64203e8cd4aa5d42496a71d80
1 change: 1 addition & 0 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4313,6 +4313,7 @@ def test_issue_89047(self):

def test_issue_102402_100msecs(self):
Comment thread
serhiy-storchaka marked this conversation as resolved.
Outdated
tests = (
# time_ns is approx. 2023-03-04 04:25:20 UTC
# (time_ns, expected_msecs_value)
(1_677_902_297_100_000_000, 100.0), # exactly 100ms
(1_677_903_920_999_998_503, 999.0), # check truncating doesn't round
Expand Down