Skip to content

GH-102126: fix deadlock at shutdown when clearing thread states #102222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Feb 25, 2023
Merged

GH-102126: fix deadlock at shutdown when clearing thread states #102222

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ade043
fix deadlock with reentrant calls to get head lock
kumaraditya303 Feb 24, 2023
b3cac6d
improve comment
kumaraditya303 Feb 24, 2023
1e6a87b
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve comment
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Feb 24, 2023
commit b3cac6d10a83a36d3a4f9a6c9af447fbc9d32c4d
1 change: 1 addition & 0 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,7 @@ interpreter_clear(PyInterpreterState *interp, PyThreadState *tstate)
PyThreadState *p = interp->threads.head;
HEAD_UNLOCK(runtime);
while (p != NULL) {
// See https://github.com/python/cpython/issues/102126
// Must be called without HEAD_LOCK held as it can deadlock
// if any finalizer tries to acquire that lock.
PyThreadState_Clear(p);
Expand Down