Skip to content

bpo-35065: Remove StreamReaderProtocol._untrack_reader #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 3 commits into from
Nov 8, 2018
Merged

bpo-35065: Remove StreamReaderProtocol._untrack_reader #10212

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
214adcf
Remove `StreamReaderProtocol._untrack_reader`
vxgmichel Oct 29, 2018
5e74a88
Add the Misc/NEWS entry for bpo-35065
vxgmichel Oct 29, 2018
06b9068
Add test_eof_feed_when_closing_writer for bpo-35065
vxgmichel Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add the Misc/NEWS entry for bpo-35065
  • Loading branch information
@vxgmichel
vxgmichel committed Oct 29, 2018
commit 5e74a88c7f4eab441eaa13db66af368c2e1423e5
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2018-10-29-10-18-31.bpo-35065.CulMN8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Remove `StreamReaderProtocol._untrack_reader`. The call to `_untrack_reader`
is currently performed too soon, causing the protocol to forget about the
reader before `connection_lost` can run and feed the EOF to the reader.