Skip to content

gh-62432: unittest runner: Exit code 5 if no tests were run #102051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 13 commits into from
Apr 27, 2023
Merged

gh-62432: unittest runner: Exit code 5 if no tests were run #102051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0a2007d
Refactor test_program to allow for multiple test suites
stefanor Feb 19, 2023
6532200
Refactor test_program to use assertRaises as a context manager
stefanor Feb 19, 2023
ebba337
unittest: Print an error message if no tests ran
stefanor Feb 19, 2023
5e1a88d
unittest runner: Exit code 5 if no tests were run
stefanor Feb 19, 2023
fb67714
Count the test run in our stub test so that the suite succeeds
stefanor Feb 19, 2023
0687ca8
Update ACKs
stefanor Feb 19, 2023
3ac2e71
Put success first in the if ladder
stefanor Feb 20, 2023
7470779
NO TESTS RAN, in past tense
stefanor Feb 20, 2023
ecb363c
The parameter name was testcase
stefanor Feb 20, 2023
7d6c322
Drop a comma
stefanor Feb 20, 2023
058e22c
Merge branch 'main' into fail-zero-tests
hauntsaninja Feb 20, 2023
455ca8b
Merge branch 'main' into fail-zero-tests
AlexWaygood Apr 26, 2023
9fbab36
move 5 to a _NO_TESTS_EXITCODE constant.
gpshead Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NO TESTS RAN, in past tense
  • Loading branch information
@stefanor
stefanor committed Feb 20, 2023
commit 747077946d45a1e830c239f9a9b3729ec728b396
2 changes: 1 addition & 1 deletion Lib/test/test_unittest/test_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def test_ExitEmptySuite(self):
testLoader=self.TestLoader(self.Empty))
self.assertEqual(cm.exception.code, 5)
out = stream.getvalue()
self.assertIn('\nNO TESTS RUN\n', out)
self.assertIn('\nNO TESTS RAN\n', out)


class InitialisableProgram(unittest.TestProgram):
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_unittest/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ class EmptyTest(unittest.TestCase):
runner = getRunner()
runner.run(suite)

self.assertIn("\nNO TESTS RUN\n", runner.stream.getvalue())
self.assertIn("\nNO TESTS RAN\n", runner.stream.getvalue())


class TestModuleCleanUp(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion Lib/unittest/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def run(self, test):
if errored:
infos.append("errors=%d" % errored)
elif run == 0:
self.stream.write("NO TESTS RUN")
self.stream.write("NO TESTS RAN")
else:
self.stream.write("OK")
if skipped:
Expand Down