Skip to content

gh-101561: Add typing.override decorator #101564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 10 commits into from
Feb 27, 2023
Merged

gh-101561: Add typing.override decorator #101564

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2349bb
PEP 698: Add typing.override decorator
stroxler Feb 3, 2023
bd3b6ac
Add missing `For example::` in the rst doc
stroxler Feb 4, 2023
c3b9b7f
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 4, 2023
c7cecf8
Update Doc/library/typing.rst
stroxler Feb 4, 2023
2acf32f
Add whatsnew entry, as per Alex Waygood's suggestion
stroxler Feb 4, 2023
6bd3356
Add ACKS entry, fix rst errors
stroxler Feb 4, 2023
42277cb
Fix title underline length in whatisnew doc.
stroxler Feb 4, 2023
afb74de
Update Misc/NEWS.d/next/Library/2023-02-04-16-35-46.gh-issue-101561.X…
stroxler Feb 4, 2023
090d9d2
Use a positional-only argument named `method`
stroxler Feb 4, 2023
f6c00e5
Apply suggestions from code review
stroxler Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a positional-only argument named method 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
  • Loading branch information
@stroxler
stroxler committed Feb 27, 2023
commit 090d9d294a889b833372342cd65ed129e1984bd9
6 changes: 3 additions & 3 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3455,7 +3455,7 @@ def decorator(cls_or_fn):



def override(__arg: F) -> F:
def override(method: F, /) -> F:
"""Indicate that a method is intended to override a method in a base class.

Usage:
Expand All @@ -3482,10 +3482,10 @@ def method(self) -> None:

"""
try:
__arg.__override__ = True
method.__override__ = True
except (AttributeError, TypeError):
# Skip the attribute silently if it is not writable.
# AttributeError happens if the object has __slots__ or a
# read-only property, TypeError if it's a builtin class.
pass
return __arg
return method