Skip to content

gh-89419: gdb: fix printing AttributeError in py-locals when no frame is available #100611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 2 commits into from
Jan 3, 2023
Merged

gh-89419: gdb: fix printing AttributeError in py-locals when no frame is available #100611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440fba5
bpo-45256: gdb: fix printing AttributeError in py-locals when no fram…
eli-schwartz Dec 30, 2022
08cc767
Update Misc/NEWS.d/next/Tools-Demos/2022-12-29-19-22-11.bpo-45256.a0e…
pablogsal Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-45256: gdb: fix printing AttributeError in py-locals when no fram… 
…e is available

```
Unable to read information on python frame
Python Exception <class 'AttributeError'>: 'NoneType' object has no attribute 'co_name'
```

Regression in commit b4903af. While
refactoring the code into a while loop, the previous early return when
no frame exists went missing. We have just printed a message that we
cannot get information about this, so the frame will be None, and we
cannot attempt to use it.

Discovered on python 3.11, in python 3.12a2 this should error out with
`.is_shim()` instead of `co_name`.
  • Loading branch information
@eli-schwartz
eli-schwartz committed Dec 30, 2022
commit 440fba5d127f69ff81161542724d13c2f19b818a
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2022-12-29-19-22-11.bpo-45256.a0ee_H.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix confusing AttributeError in python-gdb.py when py-locals is used without a frame.
Comment thread
pablogsal marked this conversation as resolved.
Outdated
1 change: 1 addition & 0 deletions Tools/gdb/libpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,6 +2108,7 @@ def invoke(self, args, from_tty):
while True:
if not pyop_frame:
print(UNABLE_READ_INFO_PYTHON_FRAME)
break
if pyop_frame.is_shim():
break

Expand Down