Skip to content

gh-100374: Fixed a bug in socket.getfqdn() #100375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 7 commits into from
Dec 21, 2022
Merged

gh-100374: Fixed a bug in socket.getfqdn() #100375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77c52fc
Fixed a bug in socket.getfqdn()
YuriNek0 Dec 20, 2022
34f6fa3
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 20, 2022
7f5cd30
Merge branch 'main' into main
YuriNek0 Dec 21, 2022
2034fab
Added test case for GH-100374.
YuriNek0 Dec 21, 2022
c2fb7f6
Update Misc/NEWS.d/next/Core and Builtins/2022-12-20-16-14-19.gh-issu…
YuriNek0 Dec 21, 2022
908cd68
Update Lib/socket.py with proper format
YuriNek0 Dec 21, 2022
e9077fd
Merge branch 'main' into main
YuriNek0 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test case for GH-100374.
  • Loading branch information
@YuriNek0
YuriNek0 committed Dec 21, 2022
commit 2034fabbdfd1c7876ff4713fc68eca18d4044ae5
4 changes: 4 additions & 0 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,10 @@ def test_getaddrinfo_ipv6_basic(self):
)
self.assertEqual(sockaddr, ('ff02::1de:c0:face:8d', 1234, 0, 0))

def test_getfqdn_filter_localhost(self):
self.assertEqual(socket.getfqdn(), socket.getfqdn("0.0.0.0"))
self.assertEqual(socket.getfqdn(), socket.getfqdn("::"))

@unittest.skipUnless(socket_helper.IPV6_ENABLED, 'IPv6 required for this test.')
@unittest.skipIf(sys.platform == 'win32', 'does not work on Windows')
@unittest.skipIf(AIX, 'Symbolic scope id does not work')
Expand Down