Skip to content

gh-100228: Warn from os.fork() if other threads exist. #100229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 20 commits into from
Dec 29, 2022
Merged

gh-100228: Warn from os.fork() if other threads exist. #100229

Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b5a53af
Warn from os.fork() if other threads exist.
gpshead Dec 14, 2022
f4a1dda
fix existing tests for the new warning.
gpshead Dec 14, 2022
bca33f9
static
gpshead Dec 14, 2022
d0eb2f6
&_Py_ID() for _active and _limbo.
gpshead Dec 14, 2022
fb098f1
news wording tweak
gpshead Dec 14, 2022
67e2b75
Add platform API calls on Linux & Mac, polish up.
gpshead Dec 14, 2022
e418723
Merge branch 'warn/os.fork/threads' of github.com:gpshead/cpython int…
gpshead Dec 14, 2022
2031888
Probably fix the macOS crashes.
gpshead Dec 14, 2022
546fac1
Fix test_os race condition.
gpshead Dec 15, 2022
a2e753e
remove the already_warned logic.
gpshead Dec 15, 2022
5655d59
Improve the warning message.
gpshead Dec 15, 2022
7c9205e
Update Misc/NEWS.d/next/Library/2022-12-13-17-29-09.gh-issue-100228.b…
gpshead Dec 15, 2022
2854473
Update a comment
gpshead Dec 15, 2022
1d3ec86
Clean up comments; add a final PyErr_Clear warning
gpshead Dec 15, 2022
0d95679
Improve test_os robustness.
gpshead Dec 15, 2022
f6a7b6e
ignore expected warnings.
gpshead Dec 15, 2022
0ca9fc7
improve error message.
gpshead Dec 15, 2022
a91a4d1
silence the warning in more tests.
gpshead Dec 15, 2022
dc8fe08
line length fixes, comments++, DECREF vs XDECREF
gpshead Dec 29, 2022
f10ece0
Merge branch 'main' into warn/os.fork/threads
gpshead Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Library/2022-12-13-17-29-09.gh-issue-100228.bgtzMV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
A :exc:`DeprecationWarning` may be raised when :func:`os.fork()` or
:func:`os.forkpty()` is called from multi-threaded processes. This is to
help people realize they are doing something unsafe. Lack of this seeing a
warning does not imply safety.
help people realize they are doing something unsafe. Lack of a warning
does not indicate that the fork call was actually safe.