Skip to content

gh-100176: Tools/iobench: Remove redundant compat code for Python <= 3.2 #100197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 7 commits into from
Apr 8, 2023
Merged

gh-100176: Tools/iobench: Remove redundant compat code for Python <= 3.2 #100197

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
21105fc
Remove compatibilty for Python < 3.3
hugovk Dec 12, 2022
25663f3
Remove compatibilty for Python 2
hugovk Dec 12, 2022
e1dadc2
Remove compatibilty note for Python 2.6 and 3.0-3.6
hugovk Dec 12, 2022
1ee3e50
Remove compatibilty for Python 2
hugovk Dec 12, 2022
902f9a2
Whitespace between functions
hugovk Dec 12, 2022
59f2f14
Use f-strings
hugovk Dec 12, 2022
3936f0d
Use builtin % formatter
hugovk Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove compatibilty for Python 2
  • Loading branch information
@hugovk
hugovk committed Dec 12, 2022
commit 1ee3e500b54f2b282bbe7f28827b959b4a0c7cb3
3 changes: 1 addition & 2 deletions Tools/iobench/iobench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ def text_open(fn, mode, encoding=None):
try:
return open(fn, mode, encoding=encoding or TEXT_ENCODING)
except TypeError:
if 'r' in mode:
mode += 'U' # 'U' mode is needed only in Python 2.x
return open(fn, mode)


def get_file_sizes():
for s in ['20 KiB', '400 KiB', '10 MiB']:
size, unit = s.split()
Expand Down