Repository navigation
test_tar test_add_dir_getmember fails if uid/gid is larger than 16777215 #95675
Description
Bug report
The test_add_dir_getmember added in #30283 fails if the current user's uid or gid is larger than 16777215 because of limitations of UStar format.
Note that the other test cases don't have this problem.
This test should either avoid depending on the current user's uid/gid (such as by using an explicit uid/gid) or be skipped if the current uid/gid is 8**8 or larger.
For example,
def filter(tarinfo):
tarinfo.uid = 100
tarinfo.gid = 100
return tarinfo
...
tar.add(name, filter=filter)Will use 100 as the uid and gid instead of the current user's uid/gid.
Activity
corona10 commentedon Feb 18, 2023
@colesbury
I will try to introduce this issue into the internal OSS sprint as the good first bug.
I will delegate the issue to my mentees.
uyw4687 commentedon Feb 20, 2023
I'll take it :)
pythongh-95675 fix uid and gid at test_add_dir_getmember
pythongh-95675 Skip if getuid or getgid is not in os
gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207)
pythongh-95675: fix uid and gid at test_add_dir_getmember (pythongh-1…
pythongh-95675: fix uid and gid at test_add_dir_getmember (pythongh-1…
[3.11] gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207) (
[3.10] gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207) (
corona10 commentedon Feb 25, 2023
Thank you @uyw4687!