Skip to content

Enable sqlite extensions in the Windows build #95656

Description

@pfmoore

Feature or enhancement

Enable SQLite extension loading in the Windows build (in the sqlite DLL shipped with Python, and in the stdlib sqlite3 module).

Pitch

At the moment, sqlite extensions are disabled at compile time - see the note in the docs. On Windows, though:

  1. We supply our own sqlite DLL, so we control the build options, and
  2. Users rarely build their own copy of Python.

So the reasons for not enabling extension loading don't really apply there, and conversely, people who want to use extensions cannot do so without limiting themselves to custom Python builds.

Previous discussion

See https://discuss.python.org/t/should-we-audit-enabling-loading-of-sqlite3-extensions-shared-libraries/8124/9

Activity

  1. moved this to TODO: Feature in sqlite3 issueson Aug 4, 2022
  2. erlend-aasland commented on Aug 4, 2022

    @erlend-aasland
    Contributor

    +1

    I'll create a patch.

    As I said on Discourse, I'd like to make it possible to enable extension loading via sqlite3_db_config(), but that is out of scope for this issue.

  3. added a commit that references this issue on Aug 4, 2022
  4. Repository owner moved this from TODO: Feature to Done in sqlite3 issueson Aug 4, 2022
  5. added a commit that references this issue on Aug 4, 2022
  6. added a commit that references this issue on Aug 4, 2022
  7. added a commit that references this issue on Aug 4, 2022
  8. added
    type-bugAn unexpected behavior, bug, or error
    and removed
    type-featureA feature request or enhancement
    on Aug 4, 2022
  9. erlend-aasland commented on Aug 4, 2022

    @erlend-aasland
    Contributor

    Repeating #95662 (comment):

    Aha... no backport to 3.10 is needed. I changed the #ifdef guard in 3.11, while Christian and I were updating configure.ac. So... this means I broke this for Windows builds in 3.11.

    FTR, broken in gh-29434.

  10. added a commit that references this issue on Aug 4, 2022
  11. pfmoore commented on Aug 4, 2022

    @pfmoore
    MemberAuthor

    lol, I'd forgotten that by installing 3.11b5, it was now my default, so when I checked and it wasn't working I assumed that was normal, rather than a 3.11 regression.

    Thanks for fixing it, and sorry for misreporting it!

  12. added a commit that references this issue on Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions