Repository navigation
Python3.11: sqlite3.connect passes more arguments to factory() #95132
Description
Hello,
Bug report
Consider the following code snippet:
$ cat /tmp/test.py
import sqlite3
class SqliteConnection(sqlite3.Connection):
def __init__(self, *args, **kwargs):
print(args)
print(kwargs)
super(SqliteConnection, self).__init__(*args, **kwargs)
db_path = '/tmp/foo.db'
sqlite3.connect(db_path, factory=SqliteConnection)And the execution:
$ python3.10 /tmp/test.py
('/tmp/foo.db',)
{'factory': <class '__main__.SqliteConnection'>}
$ python3.11 /tmp/test.py
('/tmp/foo.db', 5.0, 0, '', 1, <class '__main__.SqliteConnection'>, 128, 0)
{}The default values of sqlite3.connect's arguments are passed to the factory in
Python3.11, which was not the case in Python3.10. This means that code like
this will fail:
$ cat /tmp/failure.py
import sqlite3
class SqliteConnection(sqlite3.Connection):
def __init__(self, *args, **kwargs):
kwargs['timeout'] = 42
super(SqliteConnection, self).__init__(*args, **kwargs)
db_path = '/tmp/foo.db'
sqlite3.connect(db_path, factory=SqliteConnection)$ python3.10 /tmp/failure.py
$
$ python3.11 /tmp/failure.py
Traceback (most recent call last):
File "/tmp/failure.py", line 11, in <module>
sqlite3.connect(db_path, factory=SqliteConnection)
File "/tmp/failure.py", line 7, in __init__
super(SqliteConnection, self).__init__(*args, **kwargs)
TypeError: Connection() takes at most 8 arguments (9 given)Your environment
This behaviour appeared in 185ecdc and affects
Python 3.11 and later.
It was mentioned in #93044 (see the
second bullet point in the reporter's message) but has not been fixed.
Metadata
Metadata
Assignees
Labels
Projects
- Status
Activity
erlend-aasland commentedon Jul 22, 2022
Thanks for the report. This is unfortunate. Reverting the offending commit is going to be hairy; there has been a lot of changes since that point in time.
The only thing
sqlite3.connectneeds in order to relay the call tosqlite3.Connection.__init__is:*args,**kwargs, andfactory. Unfortunately, doing such a manoeuvre is impossible (AFAIK) with Argument Clinic. Trying to bend AC to our needs, could be an option. Another option is to just parse thefactoryargument manually (kinda like the old code), and pass the rest using vector call (orPyObject_Call). I've already tried to look for a way to do these things because of keyword-only argument needs in another PR (#93823); I might actually be able to adopt that approach.@serhiy-storchaka, do you have an opinion here?
Thanks again for testing the 3.11 beta! Reports like this help us improve.
erlend-aasland commentedon Jul 22, 2022
FTR, this won't work. Arguments will still be passed incorrectly.
[alt 1] pythongh-95132: partially revert 185ecdc
erlend-aasland commentedon Jul 22, 2022
I've partially reverted 185ecdc in #95146.
[alt 2] pythongh-95132: use vectorcall
erlend-aasland commentedon Jul 22, 2022
I've updated #95146 to use
METH_FASTCALLandPyObject_Vectorcall.gh-95132: Correctly relay *args and **kwds from sqlite3.connect to fa…
[3.11] pythongh-95132: Correctly relay *args and **kwds from sqlite3.…
erlend-aasland commentedon Jul 23, 2022
Fixed in:
[3.11] gh-95132: Correctly relay *args and **kwds from sqlite3.connec…
vstinner commentedon Aug 1, 2022
Nice fix.