Repository navigation
test_sqlite3.test_dbapi: Extended error codes aren't actually tested #93115
Description
Bug report
In 456e27a / GH-28076, @erlend-aasland added extended error codes to test_module_constants - however, they use sqlite.version_info, documented as (emphasis mine):
The version number of this module, as a tuple of integers. This is not the version of the SQLite library.
Which has been set to "2.6.0" for the past 12 years or so:
cpython/Modules/_sqlite/module.h
Line 29 in a458be3
Causing that code to never be run at all. sqlite.sqlite_version_info should probably be used instead.
Additionally, the last statement does:
cpython/Lib/test/test_sqlite3/test_dbapi.py
Line 300 in a458be3
instead of consts.append, which would cause a NameError if the conditions above were correct.
Preparing a PR to fix this.
(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))
Your environment
- CPython versions tested on: The affected code was added in v3.11.0a2.
- Operating system and architecture: Archlinux x86_64
Activity
erlend-aasland commentedon May 23, 2022
Thanks!
GH-93115: Fix version check in sqlite3 module constants test (#93116)
pythonGH-93115: Fix version check in sqlite3 module constants test (p…
erlend-aasland commentedon May 23, 2022
Resolved by:
GH-93115: Fix version check in sqlite3 module constants test (GH-93116)