Skip to content

Improvements for stable ABI definition files #91324

Closed
Closed
Improvements for stable ABI definition files#91324

Description

@encukou
encukou
opened on Mar 30, 2022
BPO 47168
Nosy @encukou, @arhadthedev
PRs
  • bpo-47168: Mark files generated by make regen-limited-abi as generated #32195
  • bpo-47169: Add feature macro PY_HAVE_THREAD_NATIVE_ID to the stable ABI definition #32365
  • bpo-47168: List feature macros in the stable ABI manifest, improve tests #32415
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2022-03-30.15:39:32.343>
labels = []
title = 'Improvements for stable ABI definition files'
updated_at = <Date 2022-04-08.14:02:39.376>
user = 'https://github.com/encukou'

    bugs.python.org fields:

    activity = <Date 2022-04-08.14:02:39.376>
actor = 'petr.viktorin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2022-03-30.15:39:32.343>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 47168
keywords = ['patch']
message_count = 4.0
messages = ['416376', '416388', '416492', '416985']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'arhadthedev']
pr_nums = ['32195', '32365', '32415']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue47168'
versions = []

    Activity

    1. encukou commented on Mar 30, 2022

      @encukou
      encukou
      on Mar 30, 2022
      MemberAuthor

      This issue groups together a few changes I'd like to make:

      • Rename Doc/data/stable_abi.dat to *.csv, so it gets syntax highlighting. (The only user of that file should be the Sphinx extension)
      • Mark autogenerated files as such in .gitattributes
      • Convert Misc/stable_abi.txt to TOML, and change the parser to match (this will need a heads-up on python-dev)
        • adjust the devguide to stable_abi.toml

    2. arhadthedev commented on Mar 30, 2022

      @arhadthedev
      arhadthedev
      on Mar 30, 2022
      Member

      Probably, regen-limited-abi needs to be called from regen-all so 'Check if generated files are up to date' CI job will become aware of it.

    3. encukou commented on Apr 1, 2022

      @encukou
      encukou
      on Apr 1, 2022
      MemberAuthor

      New changeset 079143d by Petr Viktorin in branch 'main':
      bpo-47168: Mark files generated by make regen-limited-abi as generated (GH-32195)
      079143d

    4. encukou commented on Apr 8, 2022

      @encukou
      encukou
      on Apr 8, 2022
      MemberAuthor

      Thinking more about Doc/data/stable_abi.dat, I don't think the rename is worth it. The file is not meant to be used/edited by humans.
      If someone needs the data for something other than running the Sphinx extension, let me know. We should provide a proper data source for their use case.

    5. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    6. encukou
      added 2 commits that reference this issue on Apr 28, 2022

      gh-91324: List feature macros in the stable ABI manifest, improve tes…

      6dcbc08

      gh-91324: Convert the stable ABI manifest to TOML (GH-92026)

      83bce8e

    7. encukou commented on Apr 29, 2022

      @encukou
      encukou
      on Apr 29, 2022
      MemberAuthor

      The manifest is now TOML.
      CPython: #92026
      Devguide: python/devguide#847

    8. encukou
      closed this as completedon Apr 29, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      No labels
      No labels

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions