Repository navigation
typing: get_type_hints can't handle stringified annotations with leading spaces #90710
Description
| BPO | 46552 |
|---|---|
| Nosy | @gvanrossum, @ericvsmith, @JelleZijlstra, @sobolevn, @Fidget-Spinner, @AlexWaygood, @GBeauregard |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2022-01-27.22:50:26.308>
created_at = <Date 2022-01-27.20:04:08.321>
labels = ['type-bug', '3.9', '3.10', '3.11', 'invalid', 'library']
title = "typing: get_type_hints can't handle stringified annotations with leading spaces"
updated_at = <Date 2022-01-27.22:50:26.307>
user = 'https://github.com/GBeauregard'bugs.python.org fields:
activity = <Date 2022-01-27.22:50:26.307>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-27.22:50:26.308>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2022-01-27.20:04:08.321>
creator = 'GBeauregard'
dependencies = []
files = []
hgrepos = []
issue_num = 46552
keywords = []
message_count = 5.0
messages = ['411914', '411915', '411920', '411925', '411931']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'eric.smith', 'JelleZijlstra', 'sobolevn', 'kj', 'AlexWaygood', 'GBeauregard']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46552'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
GBeauregard commentedon Jan 27, 2022
I discovered while investigating the viability of moving dataclasses.py to using typing.py's internal type introspection tools that it can't handle stringified annotations with leading spaces.
This is covered in dataclasses unit tests:
cpython/Lib/test/test_dataclasses.py
Line 3033 in 26b0482
The relevant failing code in typing.py is here:
cpython/Lib/typing.py
Line 671 in 26b0482
Leading spaces are treated like indention so there's a syntax error.
This would be trivial to fix by adding an lstrip() to the compilation code, but it's not clear to me this should be considered a bug. Should this be left as-is, or changed? I'm happy to submit a patch if there's agreement it's a bug.
JelleZijlstra commentedon Jan 27, 2022
I vote we don't change this. PEP-484 says:
But compile() fails for leading whitespace.
I also don't see a real use case for this. The dataclasses tests were presumably just added for completeness. If there's evidence this is a common pattern in the wild maybe we can reconsider.
ericvsmith commentedon Jan 27, 2022
The dataclasses tests were in fact just added for completeness. I'd be okay with changing dataclasses to reject leading spaces.
gvanrossum commentedon Jan 27, 2022
We should not accept leading spaces.--
--Guido (mobile)
AlexWaygood commentedon Jan 27, 2022
I agree with Jelle and Guido