Skip to content

add pathlib.Path.walk method #90385

Closed
Closed

Description

@Ovsyanka83
mannequin
BPO 46227
Nosy @merwok, @barneygale, @ajoino, @Ovsyanka83
PRs
  • bpo-46227: Add pathlib.Path.walk method #30340
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2022-01-02.18:34:12.724>
    labels = ['type-feature', 'library', '3.11']
    title = 'add pathlib.Path.walk method'
    updated_at = <Date 2022-01-08.12:58:28.255>
    user = 'https://github.com/Ovsyanka83'

    bugs.python.org fields:

    activity = <Date 2022-01-08.12:58:28.255>
    actor = 'Ovsyanka'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2022-01-02.18:34:12.724>
    creator = 'Ovsyanka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46227
    keywords = ['patch']
    message_count = 4.0
    messages = ['409511', '409514', '409994', '410098']
    nosy_count = 4.0
    nosy_names = ['eric.araujo', 'barneygale', 'ajoino', 'Ovsyanka']
    pr_nums = ['30340']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue46227'
    versions = ['Python 3.11']

    Activity

    1. self-assigned this
      on Jul 8, 2022
    2. added a commit that references this issue on Jul 22, 2022
    3. tiran commented on Jul 23, 2022

      @tiran
      Member

      GH-92517 broke tests on wasm32-wasi platform.

      ======================================================================
      FAIL: test_walk_symlink_location (test.test_pathlib.WalkTests.test_walk_symlink_location)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/Lib/test/test_pathlib.py", line 2626, in test_walk_symlink_location
          self.assertIn("link", files)
      AssertionError: 'link' not found in ['tmp3']
      ----------------------------------------------------------------------
      Ran 458 tests in 1.229s
      FAILED (failures=1, skipped=182)
      test test_pathlib failed
      
    4. reopened this on Jul 23, 2022
    5. added 2 commits that reference this issue on Jul 23, 2022
    6. added this to IDLE Issues and removed this from IDLE Issueson Jul 23, 2022
    7. zmievsa commented on Jul 24, 2022

      @zmievsa
      Contributor

      @tiran I apologize for introducing this problem and I am really thankful to you for resolving it, especially so quickly!

    8. merwok commented on Jul 24, 2022

      @merwok
      Member

      No worry! We all forgot to run the PR through buildbots before merging, so let’s just do that next time.

    9. brettcannon commented on Jul 25, 2022

      @brettcannon
      Member

      It's also partially my fault by forgetting that WASI doesn't support symlinks and thus to have you add the test guard for those sorts of platforms.

    10. zmievsa commented on Jul 26, 2022

      @zmievsa
      Contributor

      By the way, are we adding this PR into what's new? Or is it only gonna be a part of changelog? Seems big enough for what's new

    11. brettcannon commented on Jul 26, 2022

      @brettcannon
      Member

      @Ovsyanka83 it should end up in What's New. If you would like to write a PR for that I will happily review it. We also go through the changelog before release to make sure everything relevant ends up in there, so we don't have to worry about it being missed.

    12. added 3 commits that reference this issue on Jul 30, 2022
    13. added a commit that references this issue on Aug 11, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Labels

    3.11only security fixesstdlibStandard Library Python modules in the Lib/ directorytopic-pathlibtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions