You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
======================================================================
FAIL: test_walk_symlink_location (test.test_pathlib.WalkTests.test_walk_symlink_location)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Lib/test/test_pathlib.py", line 2626, in test_walk_symlink_location
self.assertIn("link", files)
AssertionError: 'link' not found in ['tmp3']
----------------------------------------------------------------------
Ran 458 tests in 1.229s
FAILED (failures=1, skipped=182)
test test_pathlib failed
@Ovsyanka83 it should end up in What's New. If you would like to write a PR for that I will happily review it. We also go through the changelog before release to make sure everything relevant ends up in there, so we don't have to worry about it being missed.
Activity
gh-90385: Add `pathlib.Path.walk()` method (GH-92517)
tiran commentedon Jul 23, 2022
GH-92517 broke tests on wasm32-wasi platform.
pythongh-90385: Add skip_unless_symlink decorator to test_walk_symlin…
gh-90385: Add skip_unless_symlink decorator to test_walk_symlink_loca…
zmievsa commentedon Jul 24, 2022
@tiran I apologize for introducing this problem and I am really thankful to you for resolving it, especially so quickly!
merwok commentedon Jul 24, 2022
No worry! We all forgot to run the PR through buildbots before merging, so let’s just do that next time.
brettcannon commentedon Jul 25, 2022
It's also partially my fault by forgetting that WASI doesn't support symlinks and thus to have you add the test guard for those sorts of platforms.
zmievsa commentedon Jul 26, 2022
By the way, are we adding this PR into what's new? Or is it only gonna be a part of changelog? Seems big enough for what's new
brettcannon commentedon Jul 26, 2022
@Ovsyanka83 it should end up in What's New. If you would like to write a PR for that I will happily review it. We also go through the changelog before release to make sure everything relevant ends up in there, so we don't have to worry about it being missed.
Merge branch 'main' into pythongh-90385/add-pathlib-path-whatsnew-sec…
Merge branch 'pythongh-90385/add-pathlib-path-whatsnew-section' of gi…
Merge branch 'main' into pythongh-90385/add-pathlib-path-whatsnew-sec…
gh-90385: Add pathlib.Path.walk what's new section (GH-95467)