Repository navigation
Use self.assertRaises instead of try/except in ctypes/test_functions.py::test_mro #90036
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-12-02.22:45:04.051>
created_at = <Date 2021-11-23.09:32:54.593>
labels = ['type-bug', 'tests', '3.9', '3.10', '3.11']
title = 'Use `self.assertRaises` instead of `try/except` in `ctypes/test_functions.py::test_mro`'
updated_at = <Date 2021-12-26.11:26:02.194>
user = 'https://github.com/sobolevn'bugs.python.org fields:
activity = <Date 2021-12-26.11:26:02.194>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-02.22:45:04.051>
closer = 'sobolevn'
components = ['Tests']
creation = <Date 2021-11-23.09:32:54.593>
creator = 'sobolevn'
dependencies = []
files = []
hgrepos = []
issue_num = 45878
keywords = ['patch']
message_count = 7.0
messages = ['406829', '406836', '409133', '409134', '409186', '409187', '409191']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'miss-islington', 'sobolevn']
pr_nums = ['29721', '29722', '29723', '29748', '30258', '30259', '30260']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45878'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
sobolevn commentedon Nov 23, 2021
Right now this test uses
try: ... except TypeError: ...to ensure that mro is consistent. This has a flaw: code intrymight not ever raise and this test would still pass.I will refactor it to use
self.assertRaisesto be 100% sure.serhiy-storchaka commentedon Nov 23, 2021
New changeset b48ac6f by Nikita Sobolev in branch 'main':
bpo-45878: convert
try/excepttoself.assertRaisesin[Lib/ctypes/test/test_functions.py](https://github.com/python/cpython/blob/main/Lib/ctypes/test/test_functions.py)(GH-29721)b48ac6f
serhiy-storchaka commentedon Dec 24, 2021
New changeset 393ff04 by Miss Islington (bot) in branch '3.9':
bpo-45878: convert
try/excepttoself.assertRaisesin[Lib/ctypes/test/test_functions.py](https://github.com/python/cpython/blob/main/Lib/ctypes/test/test_functions.py)(GH-29721) (GH-29723)393ff04
serhiy-storchaka commentedon Dec 24, 2021
New changeset a9e0b2b by Miss Islington (bot) in branch '3.10':
bpo-45878: convert
try/excepttoself.assertRaisesin[Lib/ctypes/test/test_functions.py](https://github.com/python/cpython/blob/main/Lib/ctypes/test/test_functions.py)(GH-29721) (GH-29748)a9e0b2b
serhiy-storchaka commentedon Dec 26, 2021
New changeset 11909c1 by Serhiy Storchaka in branch '3.10':
[3.10] Remove a NEWS entry for bpo-45878 (GH-30258)
11909c1
serhiy-storchaka commentedon Dec 26, 2021
New changeset 1fb7c61 by Serhiy Storchaka in branch 'main':
Remove a NEWS entry for bpo-45878 (GH-30259)
1fb7c61
serhiy-storchaka commentedon Dec 26, 2021
New changeset bee660e by Miss Islington (bot) in branch '3.9':
[3.9] Remove a NEWS entry for bpo-45878 (GH-30258) (GH-30260)
bee660e