Repository navigation
Optimize Path.cwd() in pathlib #88136
Description
| BPO | 43970 |
|---|---|
| Nosy | @ericvsmith, @kfollstad |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-04-28.23:03:04.453>
created_at = <Date 2021-04-28.20:41:53.343>
labels = ['library', '3.10', 'performance']
title = 'Optimize Path.cwd() in pathlib'
updated_at = <Date 2021-04-28.23:03:04.453>
user = 'https://github.com/kfollstad'bugs.python.org fields:
activity = <Date 2021-04-28.23:03:04.453>
actor = 'eric.smith'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-28.23:03:04.453>
closer = 'eric.smith'
components = ['Library (Lib)']
creation = <Date 2021-04-28.20:41:53.343>
creator = 'kfollstad'
dependencies = []
files = []
hgrepos = []
issue_num = 43970
keywords = ['patch']
message_count = 3.0
messages = ['392255', '392266', '392267']
nosy_count = 2.0
nosy_names = ['eric.smith', 'kfollstad']
pr_nums = ['25699']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue43970'
versions = ['Python 3.10']
Activity
kfollstad commentedon Apr 28, 2021
python3.10 -m timeit -r 5 -n 100000 -s 'from pathlib import Path' 'Path.cwd()'
100000 loops, best of 5: 206 usec per loop
python3.10-mypatch -m timeit -r 5 -n 100000 -s 'from pathlib import Path' 'Path.cwd()'
100000 loops, best of 5: 156 usec per loop
ericvsmith commentedon Apr 28, 2021
New changeset 4a85718 by kfollstad in branch 'master':
bpo-43970: Optimize Path.cwd() in pathlib by not instantiating a class unnecessarily (GH-25699)
4a85718
ericvsmith commentedon Apr 28, 2021
I'm merging this not so much because of the performance aspect, but just to remove some unnecessary code.
But in any event, thanks for the contribution!