Skip to content

Incorrect signature of CodeType.replace() #86457

Closed
Closed
Incorrect signature of CodeType.replace()#86457
Labels
3.10 (EOL)end of life3.8 (EOL)end of life3.9 (EOL)end of lifestdlibStandard Library Python modules in the Lib/ directorytopic-argument-clinictype-bugAn unexpected behavior, bug, or error

Description

@serhiy-storchaka
serhiy-storchaka
opened on Nov 8, 2020
BPO 42291
Nosy @vstinner, @larryhastings, @serhiy-storchaka, @1st1
PRs
  • gh-86457: Fix signature for code.replace(). #23199
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-11-08.10:38:14.301>
labels = ['type-bug', '3.8', '3.9', '3.10', 'library', 'expert-argument-clinic']
title = 'Incorrect signature of CodeType.replace()'
updated_at = <Date 2020-11-09.14:46:09.424>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-11-09.14:46:09.424>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Argument Clinic']
creation = <Date 2020-11-08.10:38:14.301>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 42291
keywords = ['patch']
message_count = 2.0
messages = ['380545', '380587']
nosy_count = 4.0
nosy_names = ['vstinner', 'larry', 'serhiy.storchaka', 'yselivanov']
pr_nums = ['23199']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42291'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    Linked PRs

    Activity

    1. serhiy-storchaka commented on Nov 8, 2020

      @serhiy-storchaka
      serhiy-storchaka
      on Nov 8, 2020
      MemberAuthor

      Currently the signature of types.CodeType.replace() is

      replace(self, /, *, co_argcount=-1, co_posonlyargcount=-1, co_kwonlyargcount=-1, co_nlocals=-1, co_stacksize=-1, co_flags=-1, co_firstlineno=-1, co_code=None, co_consts=None, co_names=None, co_varnames=None, co_freevars=None, co_cellvars=None, co_filename=None, co_name=None, co_lnotab=None)

      But -1 and None are incorrect values for many parameters, and even if they would be correct, they are not default values. By default, if you do not specify some argument, the value of the corresponding attribute would not be changed.

      Argument Clinic and the inspect module do not support this case.

    2. serhiy-storchaka
      added
      3.8 (EOL)end of life
      3.9 (EOL)end of life
      3.10 (EOL)end of life
      stdlibStandard Library Python modules in the Lib/ directory
      topic-argument-clinic
      type-bugAn unexpected behavior, bug, or error
      on Nov 8, 2020

    3. vstinner commented on Nov 9, 2020

      @vstinner
      vstinner
      on Nov 9, 2020
      Member

      Argument Clinic and the inspect module do not support this case.

      That's why I used -1 and None.

      But -1 and None are incorrect values for many parameters, and even if they would be correct, they are not default values. By default, if you do not specify some argument, the value of the corresponding attribute would not be changed.

      If you consider that this issue matters, you may hack the code to accept None as if no parameter was passed (pass NULL).

    4. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    5. serhiy-storchaka
      added a commit that references this issue on Dec 7, 2022

      pythongh-86457: Fix signature for code.replace().

      748a7e8
    6. serhiy-storchaka
      added 3 commits that reference this issue on Aug 7, 2023

      gh-86457: Fix signature for code.replace() (GH-23199)

      0e6e32f

      [3.12] pythongh-86457: Fix signature for code.replace() (pythonGH-23199)

      88cfea3

      [3.11] pythongh-86457: Fix signature for code.replace() (pythonGH-23199)

      3818723
    7. erlend-aasland
      added 2 commits that reference this issue on Aug 7, 2023

      pythongh-86457: Add docs for Argument Clinic @text_signature directive

      384960f

      gh-86457: Add docs for Argument Clinic @text_signature directive (#10…

      a9aeb99
    8. serhiy-storchaka
      added a commit that references this issue on Aug 9, 2023

      [3.11] gh-86457: Fix signature for code.replace() (GH-23199) (GH-107746)

      edaa0db
    9. erlend-aasland
      added 2 commits that reference this issue on Aug 9, 2023

      [3.11] pythongh-86457: Add docs for Argument Clinic @text_signature d…

      49d40b1

      [3.11] gh-86457: Add docs for Argument Clinic @text_signature directi…

      b0b26af
    10. Yhg1s
      added a commit that references this issue on Aug 16, 2023

      [3.12] gh-86457: Fix signature for code.replace() (GH-23199) (#107744)

      9864f9a
    11. serhiy-storchaka
      closed this as completedon Aug 16, 2023
    12. AA-Turner
      added a commit that references this issue on Sep 13, 2023

      python/cpython#86457: Add docs for Argument Clinic @text_signature di…

      6a0051f
    13. erlend-aasland
      added a commit that references this issue on Sep 26, 2023

      python/cpython#86457: Add docs for Argument Clinic @text_signature di…

      78318c1
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.10 (EOL)end of life3.8 (EOL)end of life3.9 (EOL)end of lifestdlibStandard Library Python modules in the Lib/ directorytopic-argument-clinictype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions