Skip to content

Reenable sendfile in shutil.copyfile() on Solaris #86009

Closed
Closed
Reenable sendfile in shutil.copyfile() on Solaris#86009
Labels
3.12only security fixesOS-unsupportedperformancePerformance or resource usagestdlibStandard Library Python modules in the Lib/ directory

Description

@kulikjak
kulikjak
mannequin
opened on Sep 23, 2020
BPO 41843
Nosy @giampaolo, @jstasiak, @kulikjak
PRs
  • bpo-41843: Reenable use of sendfile in shutil module on Solaris #23893
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-09-23.13:24:12.048>
labels = ['library', '3.9', '3.10', 'performance']
title = 'Reenable sendfile in shutil.copyfile() on Solaris'
updated_at = <Date 2021-05-21.10:28:24.286>
user = 'https://github.com/kulikjak'

    bugs.python.org fields:

    activity = <Date 2021-05-21.10:28:24.286>
actor = 'kulikjak'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-09-23.13:24:12.048>
creator = 'kulikjak'
dependencies = []
files = []
hgrepos = []
issue_num = 41843
keywords = ['patch']
message_count = 2.0
messages = ['377383', '394102']
nosy_count = 3.0
nosy_names = ['giampaolo.rodola', 'jstasiak', 'kulikjak']
pr_nums = ['23893']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue41843'
versions = ['Python 3.9', 'Python 3.10']

    Linked PRs

    Activity

    1. kulikjak commented on Sep 23, 2020

      @kulikjak
      kulikjakmannequin
      on Sep 23, 2020
      MannequinAuthor

      The use of sendfile() in shutil.copyfile() on Solaris was previously disabled in bpo-36610 due to slightly different behavior. This difference was recently accounted for in bpo-41687, and I observed no other unexpected problems/differences with sendfile.

      Can we get this reenabled? I can prepare PR, however, I am not sure whether bpo-36610 should be reverted (hence enabling sendfile in copyfile on every system where it is available) or whether I should just add Solaris to _USE_CP_SENDFILE condition.

    2. kulikjak
      added
      3.9 (EOL)end of life
      3.10 (EOL)end of life
      stdlibStandard Library Python modules in the Lib/ directory
      performancePerformance or resource usage
      on Sep 23, 2020

    3. kulikjak commented on May 21, 2021

      @kulikjak
      kulikjakmannequin
      on May 21, 2021
      MannequinAuthor

      Based on the comment https://bugs.python.org/issue43743#msg393429 I think my question is answered: bpo-36610 should not be reverted. Attached PR (which merely adds Solaris to systems where _USE_CP_SENDFILE is True) should thus be the preferred way of reenabling this.

    4. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    5. iritkatriel
      added
      3.12only security fixes
      and removed
      3.10 (EOL)end of life
      3.9 (EOL)end of life
      on Sep 11, 2022
    6. kulikjak
      added a commit that references this issue on Mar 20, 2023

      Reenable use of sendfile in shutil module on Solaris

      abf38f8
    7. kulikjak
      added a commit that references this issue on May 9, 2023

      Reenable use of sendfile in shutil module on Solaris

      54d8f1b
    8. encukou
      added
      OS-unsupported
      on Sep 19, 2024
    9. github-project-automation
      added this to Unsupported platformson Sep 19, 2024
    10. encukou
      closed this as completedon Sep 20, 2024
    11. github-project-automation
      moved this to Done in Unsupported platformson Sep 20, 2024
    12. encukou
      added a commit that references this issue on Sep 24, 2024

      gh-86009: Fix solaris detection in `_USE_CP_SENDFILE` check (GH-124289)

      b169cf3
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.12only security fixesOS-unsupportedperformancePerformance or resource usagestdlibStandard Library Python modules in the Lib/ directory

      Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions