Repository navigation
[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure #85848
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2022-01-25.17:41:06.264>
created_at = <Date 2020-09-01.01:20:55.485>
labels = ['type-bug', '3.10', '3.11', 'tests', 'OS-windows', 'expert-asyncio']
title = '[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure'
updated_at = <Date 2022-01-25.18:03:17.384>
user = 'https://github.com/aeros'bugs.python.org fields:
activity = <Date 2022-01-25.18:03:17.384>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-25.17:41:06.264>
closer = 'vstinner'
components = ['Tests', 'Windows', 'asyncio']
creation = <Date 2020-09-01.01:20:55.485>
creator = 'aeros'
dependencies = []
files = []
hgrepos = []
issue_num = 41682
keywords = ['patch']
message_count = 23.0
messages = ['376175', '376176', '391134', '392061', '396238', '396503', '399770', '402294', '404820', '408612', '411293', '411299', '411313', '411322', '411386', '411508', '411638', '411639', '411640', '411641', '411643', '411646', '411651']
nosy_count = 14.0
nosy_names = ['gvanrossum', 'terry.reedy', 'ncoghlan', 'vstinner', 'asvetlov', 'yselivanov', 'miss-islington', 'Dennis Sweeney', 'aeros', 'erlendaasland', 'sobolevn', 'kj', 'kumaraditya', 'arhadthedev']
pr_nums = ['30801', '30811', '30812', '30817', '30845', '30860', '30861']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41682'
versions = ['Python 3.10', 'Python 3.11']
Activity
aeros commentedon Sep 1, 2020
In an unrelated PR to add a new argument to the base Executor class for concurrent.futures, there was a test_asyncio failure in test_sendfile for the ProactorEventLoop tests:
======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
https://github.com/python/cpython/pull/22023/checks?check_run_id=1049760805#step:5:2373
[-]test_asyncio: Proactor[/-][+]test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+][-]test_asyncio: Proactor[/-][+]test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+]aeros commentedon Sep 1, 2020
In case the link to the logs are lost from closing and reopening the PR, it was a Windows CI test (GitHub actions) ran with the following configuration:
D:\a\cpython\cpython>"D:\a\cpython\cpython\PCbuild\amd64\python.exe" -u -Wd -E -bb -m test -uall -u-cpu -rwW --slowest --timeout 1200 -j0
== CPython 3.10.0a0 (remotes/pull/22023/merge:992cc27, Aug 31 2020, 06:11:21) [MSC v.1927 64 bit (AMD64)]
== Windows-10-10.0.17763-SP0 little-endian
== cwd: D:\a\cpython\cpython\build\test_python_6372�
== CPU count: 2
== encodings: locale=cp1252, FS=utf-8
Using random seed 491155
0:00:00 Run tests in parallel using 4 child processes (timeout: 20 min, worker timeout: 25 min)
vstinner commentedon Apr 15, 2021
I marked bpo-42124 and bpo-43539 as a duplicate of this issue.
16 remaining items
asvetlov commentedon Jan 24, 2022
Guido, I can not confirm your suggestion but it seems correct to me.
vstinner commentedon Jan 25, 2022
Test fixed on Windows 2022 by:
commit 1c705fd
Author: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Date: Tue Jan 25 02:34:47 2022 +0530
vstinner commentedon Jan 25, 2022
New changeset 75d88b9 by Miss Islington (bot) in branch '3.10':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (bpo-30860)
75d88b9
vstinner commentedon Jan 25, 2022
New changeset f9ff0bf by Miss Islington (bot) in branch '3.9':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (bpo-30861)
f9ff0bf
vstinner commentedon Jan 25, 2022
Thanks Kumar for the fix!
vstinner commentedon Jan 25, 2022
This failing test was one of my most hated test because it failed randomly for almost 2 years. I'm happy that it has been fixed :-)
Regularly, I'm asking for help to fix test_asyncio:
Last years I gave up, since almost no one replied to my requests.
[-][Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/-][+][Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+][-][Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/-][+][Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+]asvetlov commentedon Jan 25, 2022
I'm sorry, Victor.
vstinner commentedon Jan 25, 2022
As a maintainer of the Python CIs, The Night's Watch (*), it's my fault that I didn't skip these tests earlier. Honestly, it's ok to skip a bunch of tests or even remove them if there is no active maintainer.
It's also ok that there is no active maintainer if existing tests continue to pass. asyncio is far from being an exception. Just look at test_nntplib: not maintained for 9 years, https://bugs.python.org/issue40735
This test failure got more attention since it started to fail even more frequently (always?) on Windows 2022.
(*) https://pythondev.readthedocs.io/ci.html#the-night-s-watch-is-fixing-the-cis-in-the-darkness-for-you
tasty0tomato commentedon Oct 3, 2023
I built 3.11.5 on my own Windows computer, and found it passed this test on one computer, but didn't pass on another computer. I think that this issue may not be fixed completely, or I can provide needed information of the computer which this test didn't pass to find out the reason why it didn't pass.
vstinner commentedon Oct 3, 2023
This issue is closed, please open a new issue.