Repository navigation
Missing dependency on Include/cpython/frameobject.h #85646
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-10-27.03:42:46.759>
created_at = <Date 2020-08-04.14:23:53.628>
labels = ['build', '3.10']
title = 'Missing dependency on Include/cpython/frameobject.h'
updated_at = <Date 2020-10-27.04:02:03.370>
user = 'https://github.com/smontanaro'bugs.python.org fields:
activity = <Date 2020-10-27.04:02:03.370>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-27.03:42:46.759>
closer = 'vstinner'
components = ['Build']
creation = <Date 2020-08-04.14:23:53.628>
creator = 'skip.montanaro'
dependencies = []
files = []
hgrepos = []
issue_num = 41474
keywords = ['patch']
message_count = 12.0
messages = ['374809', '374810', '374811', '374812', '374813', '374815', '374816', '374817', '375026', '375027', '379729', '379731']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'skip.montanaro', 'vstinner', 'miss-islington']
pr_nums = ['21732', '22999', '23000']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue41474'
versions = ['Python 3.10']
Activity
smontanaro commentedon Aug 4, 2020
When Include/cpython/frameobject.h was created, there was no dependency added to Makefile.pre.in.
smontanaro commentedon Aug 4, 2020
Created a pull request. Hopefully I didn't muff the protocol too badly.
vstinner commentedon Aug 4, 2020
Your PR has 124 commits, that looks strange.
smontanaro commentedon Aug 4, 2020
Funny, it told me just one file had changed (Makefile.pre.in). I was attempting to make a PR against that one change from my fork of master to the main repo. Let me take another crack at it.
smontanaro commentedon Aug 4, 2020
I see what @vstinner is talking about. If you look at those commit messages, they all look to be of the form "Merge remote-tracking branch 'upstream/master'". That is, they are me syncing python/cpython/master to python/smontanaro/master. There is, in fact, just the one file changed, Makefile.pre.in, with the addition of a single dependency.
I don't know how to get rid of all those commit messages.
smontanaro commentedon Aug 4, 2020
Aside from one where I erroneously committed a change to the wrong
branch, then backed it out immediately.
vstinner commentedon Aug 4, 2020
I suggest you to create a local branch per change, rather than using "master".
I consider that "origin" is git@github.com:python/cpython.git. Check your remotes with "git remote -v".
Example where "master" is your PR 21732.
git switch -c frameobject master
git switch master
git reset --hard origin/master # revert your changes
Then fix your frameobject:
git switch master
git fetch && git merge --ff # ensure that you are up to date
git switch frameobject
git rebase master
Check what you get:
git log master.. --pretty=oneline
You should see only one commit.
Close your PR and create a new one on the "frameobject" branch.
smontanaro commentedon Aug 4, 2020
Hmmm... Seems like a bunch of extra work for a one-line change to a
Makefile... There's no easier way to create PRs for these trivial
changes?
gvanrossum commentedon Aug 8, 2020
Sorry to rain on your parade, but couldn’t this be a new package on PyPI?
gvanrossum commentedon Aug 8, 2020
Wrong issue, sorry. (Bpo bug?)
vstinner commentedon Oct 27, 2020
New changeset a6879d9 by Victor Stinner in branch 'master':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
a6879d9
miss-islington commentedon Oct 27, 2020
New changeset 562ad76 by Miss Skeleton (bot) in branch '3.9':
bpo-41474, Makefile: Add dependency on cpython/frameobject.h (GH-22999)
562ad76