Repository navigation
_PyDict_GetItemIdWithError() should call _PyDict_GetItem_KnownHash() #84755
Description
| BPO | 40575 |
|---|---|
| Nosy | @scoder, @methane |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-05-11.04:07:28.362>
created_at = <Date 2020-05-09.09:47:09.547>
labels = ['interpreter-core', 'easy', '3.9', 'performance']
title = '_PyDict_GetItemIdWithError() should call _PyDict_GetItem_KnownHash()'
updated_at = <Date 2020-05-11.04:07:28.361>
user = 'https://github.com/scoder'bugs.python.org fields:
activity = <Date 2020-05-11.04:07:28.361>
actor = 'scoder'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-11.04:07:28.362>
closer = 'scoder'
components = ['Interpreter Core']
creation = <Date 2020-05-09.09:47:09.547>
creator = 'scoder'
dependencies = []
files = []
hgrepos = []
issue_num = 40575
keywords = ['patch', 'easy (C)']
message_count = 2.0
messages = ['368506', '368604']
nosy_count = 2.0
nosy_names = ['scoder', 'methane']
pr_nums = ['20018']
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue40575'
versions = ['Python 3.9']
Activity
scoder commentedon May 9, 2020
_PyDict_GetItemIdWithError() looks up interned strings, which always have their hash value initialised. It can call _PyDict_GetItem_KnownHash() directly.
scoder commentedon May 11, 2020
New changeset 6067d4b by scoder in branch 'master':
bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError() (GH-20018)
6067d4b