Repository navigation
Add module/qualname arguments to make_dataclass for picklability #79413
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2018-11-13.14:30:46.300>
labels = ['3.7', '3.8', '3.9', '3.10', 'type-feature', 'library']
title = 'Add `module`/`qualname` arguments to make_dataclass for picklability'
updated_at = <Date 2020-06-21.00:43:53.291>
user = 'https://github.com/anntzer'bugs.python.org fields:
activity = <Date 2020-06-21.00:43:53.291>
actor = 'remi.lapeyre'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2018-11-13.14:30:46.300>
creator = 'Antony.Lee'
dependencies = []
files = []
hgrepos = []
issue_num = 35232
keywords = ['patch', 'patch']
message_count = 3.0
messages = ['329847', '332761', '342283']
nosy_count = 4.0
nosy_names = ['eric.smith', 'levkivskyi', 'cheryl.sabella', 'remi.lapeyre']
pr_nums = ['11371', '11371']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35232'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
Activity
anntzer commentedon Nov 13, 2018
Currently, dataclasses created by make_dataclass are not picklable, because their module is set to "types". It seems that this would be easily fixed by letting make_dataclass gain a
moduleand aqualnamekwarg, similarly to the Enum functional form (https://docs.python.org/3/library/enum.html#functional-api).remilapeyre commentedon Dec 30, 2018
Hi @Anthony.Lee, the __module__ is wrong indeed. The new changeset in #11371 should implement what you need.
If you don't specify the new
moduleandqualnameparameters, make_dataclass() will try to determine the correctmoduleso you should not need to change your code.csabella commentedon May 13, 2019
@eric.smith Can you take a look at this when you get a chance? Thanks!
remilapeyre commentedon Apr 11, 2024
The
modulepart of this has been separately reported at #102103 and fixed in #102104.Do we need to take care of
qualnamestill? If so I will update my pull request at #11371, otherwise we can close both this issue and its pull-request.encukou commentedon Sep 2, 2025
Adding
qualnamewould make sense to me, if you're still up to it.ericvsmith commentedon Sep 16, 2025
Agreed. @remilapeyre: Could you take a look at adding
qualname? And would this not also apply tonamedtuple?gh-79413: Add `qualname` parameter to `dataclass.make_dataclass`. (GH…