Skip to content

"__lltrace__" seems to be wrong , "__ltrace__" is correct in Misc/SpecialBuilds.txt #78607

Closed

Description

@NojimaTakahide
BPO 34426
Nosy @Mariatta, @pablogsal, @miss-islington, @danishprakash
PRs
  • bpo-34426: Fix typo in Misc/SpecialBuilds.txt #8822
  • [3.7] bpo-34426: fix typo (__lltrace__ -> __ltrace__) (GH-8822) #8915
  • [3.6] bpo-34426: fix typo (__lltrace__ -> __ltrace__) (GH-8822) #8916
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-08-25.02:08:01.544>
    created_at = <Date 2018-08-18.05:35:11.033>
    labels = ['3.8', 'type-bug', '3.7', 'docs']
    title = '"__lltrace__"  seems to be wrong , "__ltrace__" is correct in Misc/SpecialBuilds.txt'
    updated_at = <Date 2018-08-25.02:15:59.350>
    user = 'https://bugs.python.org/NojimaTakahide'

    bugs.python.org fields:

    activity = <Date 2018-08-25.02:15:59.350>
    actor = 'Mariatta'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2018-08-25.02:08:01.544>
    closer = 'Mariatta'
    components = ['Documentation']
    creation = <Date 2018-08-18.05:35:11.033>
    creator = 'Nojima Takahide'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34426
    keywords = ['patch']
    message_count = 8.0
    messages = ['323692', '323740', '323759', '323761', '324027', '324028', '324030', '324031']
    nosy_count = 6.0
    nosy_names = ['docs@python', 'Mariatta', 'pablogsal', 'miss-islington', 'Nojima Takahide', 'danishprakash']
    pr_nums = ['8822', '8915', '8916']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34426'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    Activity

    1. NojimaTakahide commented on Aug 18, 2018

      NojimaTakahidemannequin
      MannequinAuthor

      In the Section "LLTRACE" of $(Python3.6-source)/Misc/SpecialBuilds.txt , it describes variable name is "__lltrace__",however it seems to be wrong, "__ltrace__" is correct. Would someone correct this document?

    2. added
      docsDocumentation in the Doc dir
      type-bugAn unexpected behavior, bug, or error
      on Aug 18, 2018
    3. danishprakash commented on Aug 19, 2018

      danishprakashmannequin
      Mannequin

      however it seems to be wrong, "__ltrace__" is correct

      just curious how did you figure it out?

    4. pablogsal commented on Aug 19, 2018

      @pablogsal
      Member

      Content

      Hi @nojima and thank you for the report. Do you mind doing a PR?

      If not, I can do it myself if you prefer.

    5. danishprakash commented on Aug 19, 2018

      danishprakashmannequin
      Mannequin

      @pablogsal I would love to fix this up

    6. Mariatta commented on Aug 25, 2018

      @Mariatta
      Member

      New changeset 09efe49 by Mariatta (Danish Prakash) in branch 'master':
      bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
      09efe49

    7. Mariatta commented on Aug 25, 2018

      @Mariatta
      Member

      Thanks!

    8. miss-islington commented on Aug 25, 2018

      @miss-islington
      Contributor

      New changeset 0dc75f0 by Miss Islington (bot) in branch '3.7':
      bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
      0dc75f0

    9. Mariatta commented on Aug 25, 2018

      @Mariatta
      Member

      New changeset b26fcd6 by Mariatta (Miss Islington (bot)) in branch '3.6':
      bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
      b26fcd6

    10. transferred this issue fromon Apr 10, 2022
    11. sweeneyde commented on Apr 15, 2022

      @sweeneyde
      Member

      I think it may have been that the documentation was correct, but the code had a typo:

      The typo was introduced in 2012 in this commit: 3c1e481

      I think "lltrace" (the variable names in the C code) is a better abbreviation for "low-level trace".

      Since this has been around for 10 years, at this point, we could give up and do the low-level tracing if either __ltrace__ or __lltrace__ is present in the global namespace.

    12. added a commit that references this issue on Apr 16, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.7 (EOL)end of life3.8 (EOL)end of lifedocsDocumentation in the Doc dirtype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions