You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you're okay with the PR being rejected because the decision is the method isn't desired, then feel free to go ahead and create a PR, Engin! But if you want to a better chance that it will eventually go in then I would wait for consensus.
e-kayrakli commented on Jul 18, 2018
e-kayraklimannequin
Mannequin
More actions
Thanks for the response Brett! I am not going to rush, then. But if I happen to have some free time and motivation to create the PR, I will just do it. I don't mind revising or getting rejected.
nphilipp commented on Jun 25, 2020
nphilippmannequin
Mannequin
More actions
I've come across this issue lately and proposed a PR which implements this and, analogous to os.stat(), adds a follow_symlinks parameter to Path.exists().
Activity
lordmauve commentedon Jul 17, 2018
When using pathlib to manipulate paths that may be symlinks or regular files, a pattern that comes up frequently is this expression:
path.is_symlink() or path.exists()
os.path.lexists(path) can be used for this, but when using pathlib going back to os.path for this seems like defeat.
e-kayrakli commentedon Jul 17, 2018
I haven't contributed to Python yet and I can contribute this as a way for me to practice the PR process in Python.
As this is a small addition, should I create a PR right away, or wait for a consensus here?
brettcannon commentedon Jul 18, 2018
If you're okay with the PR being rejected because the decision is the method isn't desired, then feel free to go ahead and create a PR, Engin! But if you want to a better chance that it will eventually go in then I would wait for consensus.
e-kayrakli commentedon Jul 18, 2018
Thanks for the response Brett! I am not going to rush, then. But if I happen to have some free time and motivation to create the PR, I will just do it. I don't mind revising or getting rejected.
nphilipp commentedon Jun 25, 2020
I've come across this issue lately and proposed a PR which implements this and, analogous to os.stat(), adds a follow_symlinks parameter to Path.exists().
AlexWaygood commentedon Jan 8, 2023
Closing as rejected -- see comments on the PR: #21157 (comment)