Repository navigation
Document that sqlite3.Cursor.executescript disregards isolation_level #74778
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-05-19.07:40:30.081>
created_at = <Date 2017-06-07.22:26:12.665>
labels = ['3.11', 'type-bug', '3.9', '3.10', 'docs']
title = 'Document that sqlite3.Cursor.executescript disregards isolation_level'
updated_at = <Date 2021-05-19.07:40:30.080>
user = 'https://bugs.python.org/NoahLevitt'bugs.python.org fields:
activity = <Date 2021-05-19.07:40:30.080>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2021-05-19.07:40:30.081>
closer = 'berker.peksag'
components = ['Documentation']
creation = <Date 2017-06-07.22:26:12.665>
creator = 'Noah Levitt'
dependencies = []
files = ['46942', '46943']
hgrepos = []
issue_num = 30593
keywords = ['patch']
message_count = 7.0
messages = ['295376', '295567', '295813', '295815', '393908', '393928', '393929']
nosy_count = 7.0
nosy_names = ['docs@python', 'berker.peksag', 'Jim.Jewett', 'palaviv', 'Noah Levitt', 'miss-islington', 'erlendaasland']
pr_nums = ['26220', '26230', '26231']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue30593'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
NoahLevitt commentedon Jun 7, 2017
As far as I can tell, sqlite3 executescript() does not respect isolation_level. Is that true? If so, I think it's worth mentioning in the doc. Or maybe it should respect isolation_level, not sure there's any particular reason not to.
jimjjewett commentedon Jun 9, 2017
Do you have a test case that could be used to verify a patch?
(Or even a full patch?)
NoahLevitt commentedon Jun 12, 2017
Here's a test case
NoahLevitt commentedon Jun 12, 2017
And here's a fix.
Unfortunately I think the change could break people's scripts. If they have isolation_level set (not None) and use executescript(), they will have to issue an explicit call to connection.commit().
executescript() could do the commit itself explicitly after running the sql, I suppose. Then the behavior is much like the old behavior, but at least you get the performance boost of running inside a transaction. (Substantial if you pass 10k insert statements to executescript(), or something like that.)
Or, we could not change the code, and instead change the documentation. The docs could suggest wrapping the sql script with "begin;" and "commit;".
erlend-aasland commentedon May 18, 2021
Mentioning this behaviour in the documentation should be sufficient.
[-]sqlite3 executescript does not respect isolation_level?[/-][+]Document that sqlite3.Cursor.executescript disregards isolation_level[/+]berkerpeksag commentedon May 19, 2021
New changeset 76ed53c by Miss Islington (bot) in branch '3.9':
bpo-30593: Doc'ed that executescript() disregards isolation level (GH-26220)
76ed53c
berkerpeksag commentedon May 19, 2021
New changeset 1f483c0 by Miss Islington (bot) in branch '3.10':
bpo-30593: Doc'ed that executescript() disregards isolation level (GH-26220)
1f483c0