Skip to content

bool of large range raises OverflowError #73062

Closed
Closed
bool of large range raises OverflowError#73062
Assignees
rhettinger
Labels
3.7 (EOL)end of lifeinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@mdickinson
mdickinson
opened on Dec 5, 2016
BPO 28876
Nosy @rhettinger, @mdickinson, @methane, @4kir4, @serhiy-storchaka
PRs
  • bpo-28876: bool of large range raises OverflowError #699
  • bpo-28876: bool of large range raises OverflowError (#699) #734
  • bpo-28876: bool of large range raises OverflowError (#699) #735
    		•
    Files
  • range_bool.patch
  • range_bool-no_docs.patch: no docs updates
  • range_bool-c99-designated-initializers.patch: use c99 designated initializers
  • range_bool-c99-designated-initializers-indent.patch: use 4-space indent, space around "="
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/rhettinger'
closed_at = <Date 2017-03-20.07:39:08.069>
created_at = <Date 2016-12-05.09:37:42.421>
labels = ['interpreter-core', 'type-bug', '3.7']
title = 'bool of large range raises OverflowError'
updated_at = <Date 2017-03-24.20:18:43.324>
user = 'https://github.com/mdickinson'

    bugs.python.org fields:

    activity = <Date 2017-03-24.20:18:43.324>
actor = 'serhiy.storchaka'
assignee = 'rhettinger'
closed = True
closed_date = <Date 2017-03-20.07:39:08.069>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2016-12-05.09:37:42.421>
creator = 'mark.dickinson'
dependencies = []
files = ['45765', '45773', '46378', '46391']
hgrepos = []
issue_num = 28876
keywords = ['patch']
message_count = 18.0
messages = ['282402', '282405', '282414', '282418', '282506', '283137', '286008', '286048', '286055', '286089', '286092', '289772', '289778', '289786', '289876', '290129', '290130', '290132']
nosy_count = 5.0
nosy_names = ['rhettinger', 'mark.dickinson', 'methane', 'akira', 'serhiy.storchaka']
pr_nums = ['699', '734', '735']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28876'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    Activity

    1. mdickinson commented on Dec 5, 2016

      @mdickinson
      mdickinson
      on Dec 5, 2016
      MemberAuthor

      The bool of a large range raises OverflowError:

          >>> bool(range(2**63))
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    OverflowError: Python int too large to convert to C ssize_t

      This is a side-effect of len raising OverflowError, which is a general problem that's nontrivial to fix (the sq_length slot is constrained to return a ssize_t). In theory, though, it would be possible to implement nb_bool for range objects to do the right thing.

      In practice, this may well not be worth fixing, though I think it's at least worth reporting.

    2. mdickinson
      added
      3.7 (EOL)end of life
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      type-bugAn unexpected behavior, bug, or error
      on Dec 5, 2016

    3. rhettinger commented on Dec 5, 2016

      @rhettinger
      rhettinger
      on Dec 5, 2016
      Contributor

      +1 for implementing nb_bool for range objects.

    4. 4kir4 commented on Dec 5, 2016

      @4kir4
      4kir4mannequin
      on Dec 5, 2016
      Mannequin

      Here's a patch with range_bool() implementation, tests and the docs update.

      I'm not sure how it should be documented. I've specified it as
      versionchanged:: 3.6

    5. mdickinson commented on Dec 5, 2016

      @mdickinson
      mdickinson
      on Dec 5, 2016
      MemberAuthor

      I'm not sure how it should be documented.

      I think a change at this level probably isn't worth documenting in the official docs; it's enough that there's a Misc/NEWS entry for it.

    6. 4kir4 commented on Dec 6, 2016

      @4kir4
      4kir4mannequin
      on Dec 6, 2016
      Mannequin

      I've removed the documentation changes from the patch.

    7. mdickinson commented on Dec 13, 2016

      @mdickinson
      mdickinson
      on Dec 13, 2016
      MemberAuthor

      Patch LGTM. You could safely drop the initialisers beyond nb_bool in the range_as_number struct (per C99 6.7.8p21), but it's fine as it is.

    8. 4kir4 commented on Jan 22, 2017

      @4kir4
      4kir4mannequin
      on Jan 22, 2017
      Mannequin

      Following the python-dev discussion [1] I've added a variant of the patch that uses c99 designated initializers [2]

      [1] https://mail.python.org/pipermail/python-dev/2017-January/147175.html
      [2] https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html

    9. rhettinger commented on Jan 23, 2017

      @rhettinger
      rhettinger
      on Jan 23, 2017
      Contributor

      This patch looks ready to go. I'll wait a bit to see it there are any other comments. If not, I'll apply it shortly.

    10. rhettinger
      self-assigned this
      on Jan 23, 2017

    11. methane commented on Jan 23, 2017

      @methane
      methane
      on Jan 23, 2017
      Member

      LGTM, except 2-space indent.

    12. 4kir4 commented on Jan 23, 2017

      @4kir4
      4kir4mannequin
      on Jan 23, 2017
      Mannequin

      I've updated the patch to use 4-space indent (pep-7).

      I've added space around "=" (pep-7); unlike the usual
      "dict(designator=value)" -- no space around "=" for keyword argument
      (pep-8).

    13. mdickinson commented on Jan 23, 2017

      @mdickinson
      mdickinson
      on Jan 23, 2017
      MemberAuthor

      Latest patch LGTM too.

    14. serhiy-storchaka commented on Mar 17, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 17, 2017
      Member

      Akira, could you open a pull request on GitHub?

    15. 4kir4 commented on Mar 17, 2017

      @4kir4
      4kir4mannequin
      on Mar 17, 2017
      Mannequin

      Akira, could you open a pull request on GitHub?

      Done. PR 699

    16. serhiy-storchaka commented on Mar 17, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 17, 2017
      Member

      In bpo-29840 proposed an alternate and more general solution. But I think that nb_bool should be implemented for range objects since bpo-29840 is 3.7 only and nb_bool is faster.

    17. serhiy-storchaka commented on Mar 20, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 20, 2017
      Member

      Thank you Akira for your patch.

    18. serhiy-storchaka
      closed this as completedon Mar 20, 2017

    19. serhiy-storchaka commented on Mar 24, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 24, 2017
      Member

      New changeset 4276068 by Serhiy Storchaka in branch '3.5':
      bpo-28876: bool of large range raises OverflowError (#699) (#735)
      4276068

    20. serhiy-storchaka commented on Mar 24, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 24, 2017
      Member

      New changeset 6fad409 by Serhiy Storchaka in branch '3.6':
      bpo-28876: bool of large range raises OverflowError (#699) (#734)
      6fad409

    21. serhiy-storchaka commented on Mar 24, 2017

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 24, 2017
      Member

      New changeset e46fb86 by Serhiy Storchaka (4kir4) in branch 'master':
      bpo-28876: bool of large range raises OverflowError (#699)
      e46fb86

    22. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    3.7 (EOL)end of lifeinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions