Repository navigation
Avoid raising OverflowError in bool() #74026
Description
| BPO | 29840 |
|---|---|
| Nosy | @rhettinger, @terryjreedy, @mdickinson, @vstinner, @serhiy-storchaka |
| PRs | |
| Dependencies | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2017-04-23.07:14:38.991>
created_at = <Date 2017-03-17.20:27:26.527>
labels = ['interpreter-core', 'type-feature', '3.7']
title = 'Avoid raising OverflowError in bool()'
updated_at = <Date 2017-04-23.07:14:38.989>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2017-04-23.07:14:38.989>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2017-04-23.07:14:38.991>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2017-03-17.20:27:26.527>
creator = 'serhiy.storchaka'
dependencies = ['29839']
files = ['46731', '46826']
hgrepos = []
issue_num = 29840
keywords = ['patch']
message_count = 8.0
messages = ['289781', '290139', '290606', '290615', '292064', '292121', '292140', '292156']
nosy_count = 5.0
nosy_names = ['rhettinger', 'terry.reedy', 'mark.dickinson', 'vstinner', 'serhiy.storchaka']
pr_nums = ['1211']
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29840'
versions = ['Python 3.7']
Activity
serhiy-storchaka commentedon Mar 17, 2017
For now bool() raises OverflowError if __bool__ is not defined and __len__ returns large value.
Proposed patch makes bool() returning True if len() raises OverflowError.
This is an alternate solution of bpo-28876.
terryjreedy commentedon Mar 24, 2017
https://docs.python.org/3/library/functions.html#bool refers to
https://docs.python.org/3/library/stdtypes.html#truth
The latter says that values are true ("All other values are considered true") unless one of certain conditions holds. For user-defined classes, the condition is that the class defines a __bool__() or __len__() method and that the first of those methods returns the bool False or integer zero.
I easily interpret this as meaning that bool(x) (should) *always* return True or False. In particular, for user classes, any exception in user-coded __bool__ or __len__ (should be) included in "does not return integer zero or bool value False". This would mean that 'True' would truly be the default return for Bool().
There is currently an unstated exception for raised Exceptions. This issue proposes an exception to the exception for OverflowErrors (once negative lengths consistently raise ValueErrors and never OverflowErrors). While this sensible in itself, I am completely happy with the added complication. I would like to either reconsider the exception for Exceptions or make it explicit.
Patch has new text and What's New entry. Added logic in object.c looks correct.
vstinner commentedon Mar 27, 2017
Serhiy: Can you please create a pull request? It would be easier to review.
serhiy-storchaka commentedon Mar 27, 2017
This issue depends on bpo-29839. Tests are failed until the patch of bpo-29839 is merged.
vstinner commentedon Apr 21, 2017
Hum, I dislike this change since it's non-obvious what/who is raising the OverflowError. If an object calls a function in __len__() and the function raises OverflowError, should we consider that object is "true"? In temptation to guess, I prefer to not guess but passthrough the exception.
If you want to support bool(range(1<<1000)), we need to get the result of __len__() as a Python object rather than a C Py_ssize_t.
Maybe, if __len__() raises an OverflowError: call again the len(), but using the "__len__" method instead of the slot?
serhiy-storchaka commentedon Apr 22, 2017
I had similar doubts about this patch and needed opinions of other core developers.
Following patch implements this idea. I don't like it because it is too complicated.
I think that we should either document that raising an OverflowError by __len__() is normal and interpreted as true in Boolean context, or document that __len__() should return a value not larger than sys.maxsize, otherwise len() and bool() can raise an OverflowError (see bpo-15718).
vstinner commentedon Apr 22, 2017
If someone wants to return a value larger than maxsize and support bool():
it is already possible right now by defining a __bool__ method no? If yes,
I suggest to only document this CPython implementation detail (consequence
of slots, for efficiency) and suggest to use __bool__ for such corner case.
I also dislike retrying to call "__len__" method instead of the slot. It
can have annoying side effects.
serhiy-storchaka commentedon Apr 23, 2017
This was documented in bpo-15718.