You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def" #66651
I can't reproduce it either, and none of the failing stable buildbots show this error. Unfortunately we can only look at tip since we can't see your tag yet. But I doubt that's the issue...the last commit to pydoc or its tests was on the 17th, and was a one line change in an unrelated area. Last change before that was in June.
So...Larry broke it, but it is not obvious how. Could it be something
wrong with the pydoc topics update for the release?
Indeed, it looks like somehow the pydoc-topics update turned all of the values in the topics dict into bytes literals rather than plain strings.
Unfortunately, I don't have the right setup currently to look into it further, but my best guess would be that perhaps the pydoc-topics Sphinx builder needs an update for Python 3?
Activity
larryhastings commentedon Sep 22, 2014
I get a test failure in the regression test suite. This appears to be the important bit:
Traceback (most recent call last): File "/tmp/Python-3.4.2rc1/Lib/test/test_pydoc.py", line 851, in test_url_requests self.assertEqual(result, title, text) AssertionError: 'Pydoc: Error - topic?key=def' != 'Pydoc: KEYWORD def' - Pydoc: Error - topic?key=def + Pydoc: KEYWORD defI can ship 3.4.2rc1 like this, but I'd really like this fixed before 3.4.2 final.
Does anybody own pydoc? There's no "expert" listed on the Python Experts page.
(Adding you, Georg, because you're the DE.)
birkenfeld commentedon Sep 22, 2014
I have no idea about that code, and I can't reproduce the failure.
(Could the buildbots?)
bitdancer commentedon Sep 22, 2014
I can't reproduce it either, and none of the failing stable buildbots show this error. Unfortunately we can only look at tip since we can't see your tag yet. But I doubt that's the issue...the last commit to pydoc or its tests was on the 17th, and was a one line change in an unrelated area. Last change before that was in June.
larryhastings commentedon Sep 22, 2014
FWIW, 3.4.2rc1 is based on 7af0315bdfe0. (The release process creates a couple additional changesets.)
The failure is on my laptop, Ubuntu 14.04 x64.
bitdancer commentedon Sep 22, 2014
No failure running test_pydoc for me on gentoo linux with that changeset.
zware commentedon Sep 22, 2014
R. David Murray wrote (on python-committers):
Indeed, it looks like somehow the pydoc-topics update turned all of the values in the topics dict into bytes literals rather than plain strings.
Unfortunately, I don't have the right setup currently to look into it further, but my best guess would be that perhaps the pydoc-topics Sphinx builder needs an update for Python 3?
birkenfeld commentedon Sep 22, 2014
That is very likely the reason. So far nobody has run the builder with Python 3.
ned-deily commentedon Sep 22, 2014
Duplicate of bpo-21431?
birkenfeld commentedon Sep 22, 2014
Yep.