Skip to content

Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def" #66651

Closed
Closed
Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def"#66651
Labels
deferred-blockertype-bugAn unexpected behavior, bug, or error

Description

@larryhastings
larryhastings
opened on Sep 22, 2014
BPO 22461
Nosy @birkenfeld, @larryhastings, @ned-deily, @bitdancer, @zware
Superseder
  • bpo-21431: 3.4.1rc1 test_pydoc fails: pydoc_data.topics.topics values are type "bytes" not "str"
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-09-22.18:01:32.653>
created_at = <Date 2014-09-22.13:14:17.661>
labels = ['deferred-blocker', 'type-bug']
title = 'Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def"'
updated_at = <Date 2014-09-23.02:22:33.640>
user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2014-09-23.02:22:33.640>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2014-09-22.18:01:32.653>
closer = 'georg.brandl'
components = []
creation = <Date 2014-09-22.13:14:17.661>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 22461
keywords = []
message_count = 9.0
messages = ['227267', '227268', '227270', '227271', '227272', '227286', '227287', '227288', '227289']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'larry', 'ned.deily', 'r.david.murray', 'zach.ware']
pr_nums = []
priority = 'deferred blocker'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '21431'
type = 'behavior'
url = 'https://bugs.python.org/issue22461'
versions = ['Python 3.4']

    Activity

    1. larryhastings commented on Sep 22, 2014

      @larryhastings
      larryhastings
      on Sep 22, 2014
      ContributorAuthor

      I get a test failure in the regression test suite. This appears to be the important bit:

          Traceback (most recent call last):
      File "/tmp/Python-3.4.2rc1/Lib/test/test_pydoc.py", line 851, in test_url_requests
        self.assertEqual(result, title, text)
    AssertionError: 'Pydoc: Error - topic?key=def' != 'Pydoc: KEYWORD def'
    - Pydoc: Error - topic?key=def
    + Pydoc: KEYWORD def

      I can ship 3.4.2rc1 like this, but I'd really like this fixed before 3.4.2 final.

      Does anybody own pydoc? There's no "expert" listed on the Python Experts page.

      (Adding you, Georg, because you're the DE.)

    2. larryhastings
      added
      deferred-blocker
      type-bugAn unexpected behavior, bug, or error
      on Sep 22, 2014

    3. birkenfeld commented on Sep 22, 2014

      @birkenfeld
      birkenfeld
      on Sep 22, 2014
      Member

      I have no idea about that code, and I can't reproduce the failure.

      (Could the buildbots?)

    4. bitdancer commented on Sep 22, 2014

      @bitdancer
      bitdancer
      on Sep 22, 2014
      Member

      I can't reproduce it either, and none of the failing stable buildbots show this error. Unfortunately we can only look at tip since we can't see your tag yet. But I doubt that's the issue...the last commit to pydoc or its tests was on the 17th, and was a one line change in an unrelated area. Last change before that was in June.

    5. larryhastings commented on Sep 22, 2014

      @larryhastings
      larryhastings
      on Sep 22, 2014
      ContributorAuthor

      FWIW, 3.4.2rc1 is based on 7af0315bdfe0. (The release process creates a couple additional changesets.)

      The failure is on my laptop, Ubuntu 14.04 x64.

    6. bitdancer commented on Sep 22, 2014

      @bitdancer
      bitdancer
      on Sep 22, 2014
      Member

      No failure running test_pydoc for me on gentoo linux with that changeset.

    7. zware commented on Sep 22, 2014

      @zware
      zware
      on Sep 22, 2014
      Member

      R. David Murray wrote (on python-committers):

      So...Larry broke it, but it is not obvious how. Could it be something
      wrong with the pydoc topics update for the release?

      Indeed, it looks like somehow the pydoc-topics update turned all of the values in the topics dict into bytes literals rather than plain strings.

      Unfortunately, I don't have the right setup currently to look into it further, but my best guess would be that perhaps the pydoc-topics Sphinx builder needs an update for Python 3?

    8. birkenfeld commented on Sep 22, 2014

      @birkenfeld
      birkenfeld
      on Sep 22, 2014
      Member

      That is very likely the reason. So far nobody has run the builder with Python 3.

    9. ned-deily commented on Sep 22, 2014

      @ned-deily
      ned-deily
      on Sep 22, 2014
      Member

      Duplicate of bpo-21431?

    10. birkenfeld commented on Sep 22, 2014

      @birkenfeld
      birkenfeld
      on Sep 22, 2014
      Member

      Yep.

    11. birkenfeld
      closed this as completedon Sep 22, 2014
    12. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      deferred-blockertype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions