Repository navigation
Derby #6: Convert 50 sites to Argument Clinic across 8 files #64374
Description
| BPO | 20175 |
|---|---|
| Nosy | @pitrou, @larryhastings, @benjaminp, @serhiy-storchaka, @pdmccormick, @ZackerySpytz |
| PRs | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-07-12.16:13:44.680>
created_at = <Date 2014-01-07.23:48:19.938>
labels = ['extension-modules', 'type-feature', 'expert-argument-clinic']
title = 'Derby #6: Convert 50 sites to Argument Clinic across 8 files'
updated_at = <Date 2020-07-12.16:13:44.679>
user = 'https://github.com/larryhastings'bugs.python.org fields:
activity = <Date 2020-07-12.16:13:44.679>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-12.16:13:44.680>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Argument Clinic']
creation = <Date 2014-01-07.23:48:19.938>
creator = 'larry'
dependencies = []
files = ['38840', '38895', '39068']
hgrepos = []
issue_num = 20175
keywords = ['patch']
message_count = 14.0
messages = ['207620', '207764', '207825', '207826', '224757', '240146', '240461', '241207', '241208', '241209', '241222', '242474', '346086', '373561']
nosy_count = 9.0
nosy_names = ['pitrou', 'larry', 'benjamin.peterson', 'stutzbach', 'python-dev', 'serhiy.storchaka', 'killerbat', 'pdmccormick', 'ZackerySpytz']
pr_nums = ['14245']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20175'
versions = ['Python 3.5']
Activity
larryhastings commentedon Jan 7, 2014
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of files:
Modules/_io/bufferedio.c: 13 sites
Modules/_io/bytesio.c: 6 sites
Modules/_io/fileio.c: 6 sites
Modules/_io/iobase.c: 4 sites
Modules/_io/stringio.c: 5 sites
Modules/_io/textio.c: 8 sites
Modules/_multiprocessing/multiprocessing.c: 3 sites
Modules/_multiprocessing/semaphore.c: 5 sites
Talk to me (larry) if you only want to attack part of a bundle.
For instructions on how to convert a function to work with Argument
Clinic, read the "howto":
http://docs.python.org/dev/howto/clinic.html
killerbat commentedon Jan 9, 2014
I'll gladly take this bundle.
larryhastings commentedon Jan 10, 2014
Go for it!
That's weird. Why can't I assign it to you? Have you not signed and submitted a Python contributor agreement?
larryhastings commentedon Jan 10, 2014
Oops, sorry kbk.
larryhastings commentedon Aug 4, 2014
All the Derby patches should only go into trunk at this point.
serhiy-storchaka commentedon Apr 6, 2015
Proposed patch converts the _io module to Argument Clinic. Total 86 methods are converted.
serhiy-storchaka commentedon Apr 11, 2015
Updated to the tip.
python-dev commentedon Apr 16, 2015
New changeset 49007ed1a1a5 by Serhiy Storchaka in branch 'default':
Issue bpo-20175: Converted the _io module to Argument Clinic.
https://hg.python.org/cpython/rev/49007ed1a1a5
python-dev commentedon Apr 16, 2015
New changeset 2d8e4047c270 by Serhiy Storchaka in branch '3.4':
Backported tests from issue bpo-20175.
https://hg.python.org/cpython/rev/2d8e4047c270
New changeset 867c509c8c5e by Serhiy Storchaka in branch '2.7':
Backported tests from issue bpo-20175.
https://hg.python.org/cpython/rev/867c509c8c5e
serhiy-storchaka commentedon Apr 16, 2015
Thank you for your review Larry.
pdmccormick commentedon Apr 16, 2015
The smallest of typo fixes.
serhiy-storchaka commentedon May 3, 2015
Thanks Peter for the fix. Applied by Christian in 743c54a2830f.
ZackerySpytz commentedon Jun 19, 2019
PR 14245 converts Modules/_multiprocessing/semaphore.c and Modules/_multiprocessing/multiprocessing.c.
serhiy-storchaka commentedon Jul 12, 2020
New changeset 545b54d by Zackery Spytz in branch 'master':
bpo-20175: Convert Modules/_multiprocessing to the Argument Clinic (GH-14245)
545b54d