Repository navigation
Derby: Convert the audioop module to use Argument Clinic #64332
Description
| BPO | 20133 |
|---|---|
| Nosy | @larryhastings, @serhiy-storchaka |
| Dependencies | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-01-25.10:01:08.342>
created_at = <Date 2014-01-05.21:21:04.133>
labels = ['extension-modules', 'type-feature']
title = 'Derby: Convert the audioop module to use Argument Clinic'
updated_at = <Date 2014-01-26.07:38:18.840>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2014-01-26.07:38:18.840>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-01-25.10:01:08.342>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2014-01-05.21:21:04.133>
creator = 'serhiy.storchaka'
dependencies = ['20142', '20161']
files = ['33530']
hgrepos = []
issue_num = 20133
keywords = ['patch']
message_count = 10.0
messages = ['207401', '207595', '207626', '207645', '208084', '208245', '208252', '209181', '209261', '209285']
nosy_count = 3.0
nosy_names = ['larry', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20133'
versions = ['Python 3.4']
Activity
serhiy-storchaka commentedon Jan 5, 2014
Here is a patch which converts the audioop module to use Argument Clinic. 26 functions are converted. Also it adds docstrings for audioop functions.
There are two problems:
Test test_string crashes. Perhaps here is a bug in Argument Clinic (Py_buffer arguments are not initialized).
Pydoc for ratecv (and only for this function) returns:
ratecv =
larryhastings commentedon Jan 7, 2014
Can you refresh the patch? I think all the problems you cited are fixed, and also the comments Argument Clinic uses were all changed. I'll review when you have a fresh patch.
[-]Convert the audioop module to use Argument Clinic[/-][+]Derby: Convert the audioop module to use Argument Clinic[/+]serhiy-storchaka commentedon Jan 7, 2014
Here is refreshed patch.
larryhastings commentedon Jan 8, 2014
Serhiy: Assigning to you because you wrote a patch; if you don't want the issue, sorry, please undo it.
serhiy-storchaka commentedon Jan 14, 2014
Patch updated to tip (a little different generated code for Py_buffer).
I don't want to use return converters here because I want to add support for float32 and float64 in 3.5.
larryhastings commentedon Jan 16, 2014
I don't understand. Python already has "double" which is float64. Why would Python need a second floating-point type which isn't as good?
In any case, if somehow you get float32 in, we could just change the return converters then. So I would still prefer float return converters for now.
serhiy-storchaka commentedon Jan 16, 2014
I mean I want to add support for float32 and float64 in audioop functions. In that case return value of getsample(), max(), ets will be no longer integer for float format.
python-dev commentedon Jan 25, 2014
New changeset d4099b8a7d0f by Serhiy Storchaka in branch 'default':
Issue bpo-20133: The audioop module now uses Argument Clinic.
http://hg.python.org/cpython/rev/d4099b8a7d0f
larryhastings commentedon Jan 26, 2014
Christian Heimes just posted this to python-dev:
Coverity has detected an issue in this commit:
** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
/Modules/audioop.c: 1375 in audioop_ratecv_impl()
serhiy-storchaka commentedon Jan 26, 2014
See bpo-20394. This is unrelated to clicalization patch.