Repository navigation
Patch to rename HTMLParser module to lower_case #45343
Description
| BPO | 1002 |
|---|---|
| Nosy | @brettcannon, @orsenthil |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2008-05-16.04:42:28.105>
created_at = <Date 2007-08-23.20:20:17.504>
labels = ['expert-2to3', 'library']
title = 'Patch to rename HTMLParser module to lower_case'
updated_at = <Date 2008-05-16.04:42:28.104>
user = 'https://bugs.python.org/paulsmith'bugs.python.org fields:
activity = <Date 2008-05-16.04:42:28.104>
actor = 'brett.cannon'
assignee = 'collinwinter'
closed = True
closed_date = <Date 2008-05-16.04:42:28.105>
closer = 'brett.cannon'
components = ['Library (Lib)', '2to3 (2.x to 3.x conversion tool)']
creation = <Date 2007-08-23.20:20:17.504>
creator = 'paulsmith'
dependencies = []
files = ['8297', '8298']
hgrepos = []
issue_num = 1002
keywords = ['patch']
message_count = 11.0
messages = ['55200', '55202', '55216', '55257', '55258', '55259', '55266', '55495', '56122', '66797', '66896']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'dubois', 'collinwinter', 'orsenthil', 'paulsmith']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1002'
versions = ['Python 3.0']
Activity
paulsmith commentedon Aug 23, 2007
HTMLParser is renamed to html_parser.
paulsmith commentedon Aug 23, 2007
Patch to 2to3 fix_imports.
paulsmith commentedon Aug 23, 2007
Note that patch doesn't include
svn mv [Lib/HTMLParser.py](https://github.com/python/cpython/blob/main/Lib/HTMLParser.py) [Lib/html_parser.py](https://github.com/python/cpython/blob/main/Lib/html_parser.py).orsenthil commentedon Aug 24, 2007
what is this and other series of patches you have submitted, paulsmith?
I fail to understand. Why is the need for changing Library? You are just
adding up SPAM here.
paulsmith commentedon Aug 24, 2007
I am participating in the Python Sprint here at Google, and was just
going through the Py3k Sprint Tasks spreadsheet, one of them being to
rename standard library modules which use CamelCase to
lower_and_underscore, the more modern naming.
orsenthil commentedon Aug 24, 2007
But your "standalone diffs" will break things and dependencies with
other modules, so I was worried about them. Are you taking care of them all?
paulsmith commentedon Aug 24, 2007
I grep'd for HTMLParser module imports in other standard library
modules, renamed, and ran the unit tests. I also updated the mapping in
2to3's fix_imports.py. The only thing I can't do is the actual
svn mvto rename the module itself.
Is part of the problem that this issue was initially flagged as Python
2.6? It's supposed to be 3.0, but that flag wasn't available yesterday
when I opened it.
collinwinter commentedon Aug 30, 2007
orsenthil: that this will break external modules is completely
acceptable. Those modules won't work out-of-the-box with Python 3
anyway, and hopefully Paul's patch to 2to3 will alleviate some of the
burden.
dubois commentedon Sep 24, 2007
Hoping I have learned to spell, another test.
brettcannon commentedon May 13, 2008
Do note that HTMLParse is slated to become html.parser in 3.0, so these
patches are out-of-date. They can be used, though, to possibly help all
references to HTMLParser (although 2to3 should handle that).
brettcannon commentedon May 16, 2008
Closing as out of date to try to make the number of PEP-3108 issues more
manageable. HTMLParser is becoming html.parser in 3.0.