Repository navigation
Tachyon's StackTraceCollector has two different ways to set skip_idle #145458
Description
Activity
- added a commit that references this issue
on Mar 3, 2026 I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)
When you are not sure about something, please avoid create draft PRs and wait for a maintainer to acknowledge the issue. You can say that you have a PR ready in case this is acknowledge but please avoid opening PRs that are not sure to be merged.
Reacted by Thomas KowalskiSounds good, noted. Sorry about this. I'll avoid doing this in the future.
cc @pablogsal
- added a commit that references this issue
on Mar 31, 2026 - added a commit that references this issue
on Mar 31, 2026 I think we can close this, right? Now that #145459 is merged.
Reacted by Bénédikt Tran
I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)
In the
StackTraceCollector, it seems likeself.skip_idleis set but never used, as everycollectmethod gets anotherskip_idleparameter that they use in_iter_stacks(or their calls to parent class' methods).Based on the code for e.g.
live_collector, it seems like the pattern is to use the attribute, not a parameter.Linked PRs
self.skip_idle#145459