Repository navigation
Convert _interpreters to Argument Clinic #137630
Description
Activity
It seems that
_interpchannelsalso needs to be worked on.
Would it be okay for me to submit a PR(Convert_interpchannelsto use Argument Clinic)?@AA-Turner @hnnynh is a first-time sprint participant at PyCon KR, and my colleague, it would be a good task to be familiar with the CPython code base with this task.
@AA-Turner Hi,
The sprint day has wrapped up today, but I think one of the main purposes of organizing sprints is to find promising contributor candidates. Would it be okay for her to follow up on the_interpchannelsmodule if @ericsnowcurrently approves the other PR?Best,
DongheeConverting an entire module to Argument Clinic all at once can be quite tricky,
_interpqueues.cwasn't very straightforwards (it involved writing a custom converter, which is fairly advanced even for AC). I'd prefer to do_interpchannelsmyself for this reason, and to keep consistency.For a new contributor, perhaps you would want to try converting
_json.cto Argument Clinic instead? I would happy to help review @hnnynh's PR to do this @corona10 :-)There are four functions to convert in
_json, so hopefully it should not be too hard!A
Reacted by Donghee Na@AA-Turner Is this done?
No (
_interpchannelsremains).A
Feature or enhancement
Proposal:
_interpretersmodule.ccurrently exclusively usesPyArg_ParseTupleAndKeywords/PyArg_ParseTuple.Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
_interpretersto use Argument Clinic #137631_interpretersmodule.c#137680_interpqueuesto use Argument Clinic #137685_interpchannelsto use Argument Clinic #139141