Repository navigation
Reorganize WASI-related files in Tools/wasm #133600
Description
The files in Tools/wasm are a little messy as nearly all Emscripten-related files are in emscripten/ while the WASI-related files are not. So I want to:
- Add a
wasi/directory and move code related towasi.pythere - Make
wasi.pya deprecated shim for callingwasi/ - Update
CODEOWNERSsuch that @freakboy3742 isn't bothered about WASI-only stuff and I'm not bothered about Emscripten-only stuff
Linked PRs
- [3.14] GH-133600: Backport file reorg of
Tools/wasm/wasi#135950 - gh-133600: Move config.site-wasm32-emscripten into the emscripten folder #136934
- [3.14] gh-133600: Move config.site-wasm32-emscripten into the emscripten folder (GH-136934) #136956
- gh-133600: Run
Tools/wasm/wasion CI instead of deprecatedTools/wasm/wasi.py#140907 - [3.14] gh-133600: Run
Tools/wasm/wasion CI instead of deprecatedTools/wasm/wasi.py(GH-140907) #140964
Activity
brettcannon commentedon May 7, 2025
I have a PR ready to go into
mainand then to backport to 3.14, butmainis currently broken for cross-builds (should be fixed by #133599).GH-133600: Refactor `wasi.py` into `wasi/__main__.py`
Revert "pythonGH-133600: Refactor `wasi.py` into `wasi/__main__.py`"
brettcannon commentedon May 7, 2025
ee49644 was an accidental preview of the PR. 😅
brettcannon commentedon May 7, 2025
@freakboy3742 the decision was made on Discord that it was better to just leave my mistake commit, so in classic EAFP tradition I'm asking if you have any feedback on the changes I made and anything you want me to change.
freakboy3742 commentedon May 7, 2025
@brettcannon I think that all makes sense to me.
The only bigger picture question I've got is around the use of the
Toolsdirectory - I appreciate there's history and backwards compatibility issues, but if we're doing a re-org anyway, does it make any sense to promotewasmto a top-level folder in the repo, similar to every other supported platform?brettcannon commentedon May 8, 2025
Possibly. I think that's a bigger question for the overall core team (something you want to bring up at the language summit?).
brettcannon commentedon May 8, 2025
BTW I left the
config.sitefile in place for Emscripten as I wasn't sure if you wanted to move it into theemscripten/directory or not.freakboy3742 commentedon May 8, 2025
I already have a slide for this (in the context of support for other Apple platforms). 😄
4 remaining items
[3.14] pythonGH-133600: Backport file reorg of `Tools/wasm/wasi`
[3.14] GH-133600: Backport file reorg of `Tools/wasm/wasi` (GH-135950)
pythonGH-133600: Refactor `wasi.py` into `wasi/__main__.py`
pythongh-133600: Move config.site-wasm32-emscripten into the emscript…
gh-133600: Move config.site-wasm32-emscripten into the emscripten fol…
pythongh-133600: Move config.site-wasm32-emscripten into the emscript…
[3.14] gh-133600: Move config.site-wasm32-emscripten into the emscrip…
pythongh-133600: Move config.site-wasm32-emscripten into the emscript…
pythongh-133600: Move config.site-wasm32-emscripten into the emscript…
[3.14] pythongh-133600: Move config.site-wasm32-emscripten into the e…
gh-133600: Run `Tools/wasm/wasi` on CI instead of deprecated `Tools/w…
pythongh-133600: Run `Tools/wasm/wasi` on CI instead of deprecated `T…
[3.14] gh-133600: Run `Tools/wasm/wasi` on CI instead of deprecated `…
pythongh-133600: Run `Tools/wasm/wasi` on CI instead of deprecated `T…