Skip to content

Pylauncher does not correctly detect a BOM when searching for the shebang #131020

Closed
Closed
Pylauncher does not correctly detect a BOM when searching for the shebang#131020
Labels
OS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@chris-eibl
chris-eibl
opened on Mar 9, 2025

Bug report

Bug description:

This is due to

cpython/PC/launcher2.c

Lines 1080 to 1081 in 475f933

if (bytesRead > 3 && *b == 0xEF) {
if (*++b == 0xBB && *++b == 0xBF) {

for wich clang-cl creates the following warnings:

1>..\PC\launcher2.c(1080,29): warning : result of comparison of constant 239 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
1>..\PC\launcher2.c(1081,34): warning : result of comparison of constant 191 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
1>..\PC\launcher2.c(1081,18): warning : result of comparison of constant 187 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs

Activity

  1. chris-eibl
    added
    type-bugAn unexpected behavior, bug, or error
    on Mar 9, 2025

  2. StanFromIreland commented on Mar 9, 2025

    @StanFromIreland
    StanFromIreland
    on Mar 9, 2025 · Hidden as outdated
  3. picnixz
    added
    OS-windows
    buildThe build process and cross-build
    on Mar 9, 2025

  4. picnixz commented on Mar 9, 2025

    @picnixz
    picnixz
    on Mar 9, 2025 · Hidden as outdated
  5. picnixz
    closed this as not plannedon Mar 9, 2025

  6. StanFromIreland commented on Mar 9, 2025

    @StanFromIreland
    StanFromIreland
    on Mar 9, 2025 · Hidden as outdated

  7. picnixz commented on Mar 9, 2025

    @picnixz
    picnixz
    on Mar 9, 2025 · Hidden as outdated
  8. picnixz
    reopened this on Mar 10, 2025
  9. chris-eibl
    changed the title [-]Pylauncher does not correctly detect a BOM[/-] [+]Pylauncher does not correctly detect a BOM when searching for the shebang[/+] on Mar 10, 2025

  10. picnixz commented on Mar 10, 2025

    @picnixz
    picnixz
    on Mar 10, 2025
    Member

    Reopening as it appeared that this wasn't true duplicate although the errors were similar.

  11. zooba
    added a commit that references this issue on Mar 10, 2025

    gh-131020: py.exe launcher does not correctly detect a BOM when searc…

    36ef3bf
  12. miss-islington
    added 2 commits that reference this issue on Mar 10, 2025

    pythongh-131020: py.exe launcher does not correctly detect a BOM when…

    3c298ef

    pythongh-131020: py.exe launcher does not correctly detect a BOM when…

    000c2f5
  13. zooba
    added 2 commits that reference this issue on Mar 10, 2025

    [3.13] gh-131020: py.exe launcher does not correctly detect a BOM whe…

    cf829f4

    gh-131020: py.exe launcher does not correctly detect a BOM when searc…

    22ac71d

  14. picnixz commented on Mar 12, 2025

    @picnixz
    picnixz
    on Mar 12, 2025
    Member

    Closing since it was completed. Thanks for the report and fix!

  15. picnixz
    closed this as completedon Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions