Repository navigation
Missing Py_CLEAR/Py_VISIT calls for Unpickler.persistent_load_attr and Pickler.persistent_id_attr #130179
Description
Activity
- added a commit that references this issue
on Feb 16, 2025 - changed the title
[-]Possible memory leaks in _pickle[/-][+]`_pickle`: Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/+]on Feb 16, 2025 - changed the title
[-]`_pickle`: Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/-][+]Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/+]on Feb 16, 2025 - added a commit that references this issue
on Feb 16, 2025 - added a commit that references this issue
on Feb 16, 2025
Bug report
Bug description:
I found that
Unpickler.persistent_load_attrandPickler.persistent_id_attrcan be set, but never clear. However, I didn't find any uses of them.Another issue, I found that
PDATA_APPENDandPDATA_PUSHmay lead to memory leaks ifPyErr_NoMemoryis raised. What do we do about resources when this happens? I've seen resources get cleared, and sometimes they don't.CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Linked PRs
persistent_{id,load}_attrreference leaks in_pickle(GH-130180) #130190