Repository navigation
Improve performance of http.cookiejar.join_header_words #128982
Description
Activity
- added a commit that references this issue
on Feb 26, 2025 Thank you!
This is incorrect change. For example, it produces incorrect results for "foo;_" and "foo_bar".
Oof, thanks for noticing.
I'll revert and add a test.\where looks arbitrary. And it is. There are other red flags. See #130631.I'll close this one and we'll move to 130631
Feature or enhancement
Proposal:
Currently, we use
if not re.search(r"^\w+$", v):. This can be replaced byif not v.isalnum() and '_' not in v. Benchmarks are as follows:It doesn't help having a compiled regex by the way.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
http.cookiejar.join_header_wordsfor an efficient alternative #128983