Skip to content

pathlib ABCs: remove or namespace private attributes #127807

Closed
Closed
pathlib ABCs: remove or namespace private attributes#127807
Labels
stdlibStandard Library Python modules in the Lib/ directorytopic-pathlib

Description

@barneygale
barneygale
opened on Dec 11, 2024

@encukou pointed out:

I see there's currently no distinction between pathlib-internal attribute names and names that are free for third-party subclasses to use.
Should there be a stronger namespace for these, like _pathlib_sep, _pathlib_globber & _pathlib_stack?
Or should _sep & co. be documented so users know to not override them?

PurePathBase and PathBase have ~10 private attributes for facilitating copying, ~3 for matching and globbing, and ~3 more for miscellaneous purposes. We should try to eliminate as many as possible, and namespace the rest (e.g. under _pathlib_)

Linked PRs

Activity

  1. barneygale
    added
    stdlibStandard Library Python modules in the Lib/ directory
    topic-pathlib
    on Dec 11, 2024
  2. barneygale
    added 8 commits that reference this issue on Dec 11, 2024

    pythonGH-127807: pathlib ABCs: move private copying methods to dedica…

    c4ef762

    pythonGH-127807: pathlib ABCs: move private copying methods to dedica…

    4c4431d

    pythonGH-127807: pathlib ABCs: remove a few private attributes

    15614a6

    pythonGH-127807: pathlib ABCs: remove `PathBase._unsupported_msg()`

    a90839a

    pythonGH-127807: pathlib ABCs: remove `PathBase._unsupported_msg()`

    eecf733

    pythonGH-127807: pathlib ABCs: remove `PathBase._unsupported_msg()`

    032e3ef

    GH-127807: pathlib ABCs: remove `PathBase._unsupported_msg()` (#127855)

    7146f18

    pythonGH-127807: pathlib ABCs: remove `PurePathBase._raw_paths`

    2e149df
  3. barneygale
    added 6 commits that reference this issue on Dec 22, 2024

    Merge branch 'main' into pythongh-127807-raw-paths

    0765929

    GH-127807: pathlib ABCs: remove `PurePathBase._raw_paths` (#127883)

    a959ea1

    Merge branch 'main' into pythongh-127807-misc

    3dbb1e7

    GH-127807: pathlib ABCs: remove a few private attributes (#127851)

    f5ba74b

    Merge branch 'main' into pythongh-127807-copy

    6b4752b

    GH-127807: pathlib ABCs: move private copying methods to dedicated cl…

    8d9f52a

  4. barneygale commented on Dec 22, 2024

    @barneygale
    barneygale
    on Dec 22, 2024
    ContributorAuthor

    This is done, with two exceptions:

    1. PathBase._scandir() will be removed as part of Expose os.DirEntry objects from pathlib #125413
    2. PathBase._delete() will be made public some time, hopefully.
  5. barneygale
    closed this as completedon Dec 22, 2024
  6. srinivasreddy
    added 3 commits that reference this issue on Dec 23, 2024

    pythonGH-127807: pathlib ABCs: remove `PurePathBase._raw_paths` (pyth…

    37e6e64

    pythonGH-127807: pathlib ABCs: remove a few private attributes (pytho…

    3e44493

    pythonGH-127807: pathlib ABCs: move private copying methods to dedica…

    6aba8e0
  7. srinivasreddy
    added 4 commits that reference this issue on Jan 8, 2025

    pythonGH-127807: pathlib ABCs: remove `PathBase._unsupported_msg()` (p…

    f5c5bd6

    pythonGH-127807: pathlib ABCs: remove `PurePathBase._raw_paths` (pyth…

    f86d754

    pythonGH-127807: pathlib ABCs: remove a few private attributes (pytho…

    a9f3c14

    pythonGH-127807: pathlib ABCs: move private copying methods to dedica…

    db539bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytopic-pathlib

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions