Skip to content

Allow to set non-UTF8 exception messages #126742

Closed
Closed
Allow to set non-UTF8 exception messages#126742
Assignees
picnixz
Labels
3.12only security fixes3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-C-APItype-bugAn unexpected behavior, bug, or error

Description

@picnixz
picnixz
opened on Nov 12, 2024

Feature or enhancement

Proposal:

This is a follow-up to the discussion in #126555 (comment).

dlerror() may return non-UTF-8 messages, possibly translated. We should be able to set exception messages according to the current locale. To that end, we'll expose some internal helper:

extern void 
_PyErr_SetLocaleStringTstate(PyThreadState *tstate, PyObject *exception, const char *string);

extern void
_PyErr_SetLocaleString(PyObject *exception, const char *string);

cc @ZeroIntensity @encukou

For now, both functions would be only declared as extern and not part of the public C API.

Linked PRs

Activity

  1. picnixz
    added
    type-featureA feature request or enhancement
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Nov 12, 2024
  2. picnixz
    self-assigned this
    on Nov 12, 2024
  3. ZeroIntensity
    added
    topic-C-API
    on Nov 12, 2024

  4. picnixz commented on Nov 12, 2024

    @picnixz
    picnixz
    on Nov 12, 2024
    MemberAuthor

    Let's actually mark it as a bugfix since we'll need to backport it in order to use it later.

  5. picnixz
    added
    type-bugAn unexpected behavior, bug, or error
    3.12only security fixes
    3.13only security fixes
    3.14bugs and security fixes
    and removed
    type-featureA feature request or enhancement
    on Nov 12, 2024

  6. ZeroIntensity commented on Nov 12, 2024

    @ZeroIntensity
    ZeroIntensity
    on Nov 12, 2024
    Member

    Hmm, so is PyErr_SetLocaleString supposed to be implicitly private? I'm not the biggest fan of that--if something is supposed to be private, then we need to prefix it with _, not only so users don't touch it, but so people reading the source don't mistake it as public. If we want a variation of it that takes a thread state, we could have something like _PyErr_SetLocaleStringTstate.

  7. picnixz commented on Nov 12, 2024

    @picnixz
    picnixz
    on Nov 12, 2024
    MemberAuthor

    Hmm, so is PyErr_SetLocaleString supposed to be implicitly private

    For now, but maybe we can directly expose to the C API? I want to be consistent with the naming of each function.

  8. picnixz commented on Nov 12, 2024

    @picnixz
    picnixz
    on Nov 12, 2024
    MemberAuthor

    Nevermind, there is a precedent: _PyErr_FormatFromCauseTstate. Let's have
    _PyErr_SetLocaleStringTstate and _PyErr_SetLocaleString and both private.

  9. encukou commented on Nov 12, 2024

    @encukou
    encukou
    on Nov 12, 2024
    Member

    How many places in the code would use this helper? I don't see the advantage over calling PyUnicode_DecodeLocale and PyErr_SetObject.

  10. picnixz commented on Nov 12, 2024

    @picnixz
    picnixz
    on Nov 12, 2024
    MemberAuthor

    There are a few occurrences of dlerror() in _ctypes.c and callproc.c and dynload_shlib as well.

    NVM: the dynload_shlib uses its own logic.

  11. 22 remaining items

  12. picnixz
    added
    3.14bugs and security fixes
    on Dec 17, 2024

  13. picnixz commented on Dec 17, 2024

    @picnixz
    picnixz
    on Dec 17, 2024
    MemberAuthor

    I changed the labels since we decideed to eventually treat this as a bug fix.

  14. vstinner
    added a commit that references this issue on Dec 18, 2024

    gh-126742: Avoid checking for library filename in test_ctypes (#128034)

    335e24f
  15. miss-islington
    added 2 commits that reference this issue on Dec 18, 2024

    pythongh-126742: Avoid checking for library filename in test_ctypes (p…

    3deb317

    pythongh-126742: Avoid checking for library filename in test_ctypes (p…

    ededa43
  16. vstinner
    added 2 commits that reference this issue on Dec 18, 2024

    [3.12] gh-126742: Avoid checking for library filename in test_ctypes (G…

    6ffa564

    [3.13] gh-126742: Avoid checking for library filename in test_ctypes (G…

    2ff3e95
  17. encukou
    added a commit that references this issue on Dec 18, 2024

    gh-126742: add NEWS entry for fix of localized error messages (GH-128025

    2610bcc
  18. miss-islington
    added 2 commits that reference this issue on Dec 18, 2024

    pythongh-126742: add NEWS entry for fix of localized error messages (p…

    afdedc8

    pythongh-126742: add NEWS entry for fix of localized error messages (p…

    6bde434
  19. encukou
    added 2 commits that reference this issue on Dec 19, 2024

    [3.13] gh-126742: add NEWS entry for fix of localized error messages (G…

    d699ce3

    [3.12] gh-126742: add NEWS entry for fix of localized error messages (G…

    6def693
  20. srinivasreddy
    added 3 commits that reference this issue on Jan 8, 2025

    pythongh-126742: Add _PyErr_SetLocaleString, use it for gdbm & dlerro…

    f0e854d

    pythongh-126742: Avoid checking for library filename in test_ctypes (p…

    8d5f556

    pythongh-126742: add NEWS entry for fix of localized error messages (p…

    aaac7a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.12only security fixes3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-C-APItype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions