Repository navigation
Delay deprecated zipimport.zipimporter.load_module removal time to 3.15 #125746
Description
Feature or enhancement
Proposal:
This method have been deprecated since Python 3.10
At https://github.com/python/cpython/blob/main/Lib/zipimport.py#L224-L225
msg = ("zipimport.zipimporter.load_module() is deprecated and slated for "
"removal in Python 3.12; use exec_module() instead")edit: Delay the removal time to 3.15
#125746 (comment)
Activity
Damien-Chen commentedon Oct 20, 2024
Could I take this one ?
Wulian233 commentedon Oct 20, 2024
I've finish the PR
ZeroIntensity commentedon Oct 20, 2024
I would like to hold off on this change for one more version. A quick GitHub search shows that 1.8k projects are still relying on
load_module(and my regular expression isn't perfect, so I'm certain that we're missing some).The new zipimport methods (I'm using "new" loosely here, I'm talking about the 3.10 methods) were only added to typeshed in late June, so I would assume that many were intentionally using
load_moduleoverexec_module, because their IDE was telling them that it doesn't exist (to confirm that, adjusting my GitHub search shows that only 250 projects are usingexec_module). Similarly,load_moduleisn't marked as@deprecatedon typeshed, so when we did add it, it's unlikely that people realized they needed to migrate.[-]Remove deprecated `zipimport.zipimporter.load_module`[/-][+]Delay deprecated `zipimport.zipimporter.load_module` removal time to 3.15[/+]brettcannon commentedon Oct 21, 2024
@warsaw after our discussions at the core dev sprints I assume you're okay shifting this to 3.15 so it's 5 releases past 3.10 when the warning first appeared?
warsaw commentedon Oct 21, 2024
No objections from me.
gh-125746: Delay deprecated `zipimport.zipimporter.load_module` remov…