Skip to content

Compilation is broken with HAVE_DYNAMIC_LOADING=0 #122907

Closed
Closed
Compilation is broken with HAVE_DYNAMIC_LOADING=0#122907
Assignees
ericsnowcurrently
Labels
3.13only security fixes3.14bugs and security fixesOS-emscriptentopic-importlibtype-bugAn unexpected behavior, bug, or error

Description

@tritao
tritao
opened on Aug 11, 2024

Bug report

Bug description:

When compiling for Wasm with --disable-wasm-dynamic-linking, we end up with HAVE_DYNAMIC_LOADING=0, which is currently broken with the following linking errors:

wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_info_init_for_builtin
wasm-ld: error: Python/import.o: undefined symbol: _PyImport_RunModInitFunc
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_apply_error
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_info_clear
wasm-ld: error: Python/import.o: undefined symbol: _PyImport_RunModInitFunc
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_apply_error
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear

I believe its a regression introduced in 529a160.

@ericsnowcurrently, would you be able to take a look into fixing this?

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. tritao
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 11, 2024
  2. sobolevn
    added
    OS-wasi
    on Aug 11, 2024

  3. ericsnowcurrently commented on Aug 12, 2024

    @ericsnowcurrently
    ericsnowcurrently
    on Aug 12, 2024
    Member

    I'll take a look.

  4. brettcannon commented on Aug 12, 2024

    @brettcannon
    brettcannon
    on Aug 12, 2024
    Member

    Is this for Emscripten of WASI? If it's for the former it's no longer officially supported as of CPython 3.13 (code for Emsripten will start being removed in CPython 3.14/main, I just haven't gotten around to doing the removal).

  5. ericsnowcurrently
    added
    3.13only security fixes
    3.14bugs and security fixes
    topic-importlib
    and removed
    OS-wasi
    on Aug 12, 2024

  6. ericsnowcurrently commented on Aug 12, 2024

    @ericsnowcurrently
    ericsnowcurrently
    on Aug 12, 2024
    Member

    The problem manifests with HAVE_DYNAMIC_LOADING not set, regardless of any WASM-related build. I'll get builds without dynamic loading working again with a minimal change, but there are broader deficiencies to address. See gh-122950.

  7. ericsnowcurrently
    self-assigned this
    on Aug 12, 2024
  8. ericsnowcurrently
    added a commit that references this issue on Aug 13, 2024

    gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)

    ee1b8ce
  9. miss-islington
    added a commit that references this issue on Aug 13, 2024

    pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…

    70d359b
  10. blhsing
    added a commit that references this issue on Aug 22, 2024

    pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…

    8c46cb4
  11. brettcannon
    added
    OS-emscripten
    on Oct 30, 2024
  12. Yhg1s
    added a commit that references this issue on Dec 3, 2024

    [3.13] gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952

    dddea7c

  13. ZeroIntensity commented on Jan 11, 2025

    @ZeroIntensity
    ZeroIntensity
    on Jan 11, 2025
    Member

    Doing some triaging. Is this all good to close?

  14. freakboy3742 commented on Jan 11, 2025

    @freakboy3742
    freakboy3742
    on Jan 11, 2025
    Contributor

    My read is that it is good to close; there's still a related issue, but that's being tracked by #122950.

    Also - for the benefit of posterity, Emscripten support is back on for 3.14 (or, at least, myself and @hoodmane... mostly @hoodmane) are trying to restore it to Tier 3.

  15. ZeroIntensity
    closed this as completedon Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.13only security fixes3.14bugs and security fixesOS-emscriptentopic-importlibtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions